Ticket #8067 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Bug in patch version calculation

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.0
Component: Tools Keywords:
Cc: taylorrj@… Blocked By:
Blocking: Tester: Russell Taylor

Description

  • Date: Tue Oct 1 10:53:37 2013 -0400 is converted to 201310011443
  • Date: Tue Oct 1 14:29:58 2013 +0100 is converted to 201310011529 and should be 201310011329

What is happening is that things ahead of GMT (such as BST) are being corrected in the wrong direction.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Milestone changed from Backlog to Release 3.0

comment:2 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #8067. Corrected error in removing time-zone from patch version.

Changeset: 41a2c0e0de64b0f8d274b7bd03dd3ae91bd71791

comment:3 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on bugfix/8067_patch_version.

To test:

  • look at the diff
  • make a package and see what the patch version is in comparison to the last commit date/time

comment:4 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 7 years ago by Russell Taylor

Verified by checking that I get the right answer for my merge of this branch (yes) and by looking through the Jenkins results for the last UK commit to develop. This commit (N.B. github seems to go for Pacific time) correctly translated to "2.6.20131002.1402" from "Wed Oct 2 15:02:13 2013 +0100".

Incidentally, the current tip of master truly confuses things - it turns into 20131002.1211. I guess his computer's clock is wrong so we won't worry about it too much.

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/8067_patch_version'

Full changeset: b140e49d87e5d59fa3d4aa4ce7428abae5a9c4d1

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8912

Note: See TracTickets for help on using tickets.