Ticket #8147 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Batch mode and -add files.

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.0
Component: SANS Keywords:
Cc: richard.heenan@… Blocked By:
Blocking: Tester: Samuel Jackson

Description

User reported issue:

Using a –add file in batch mode for LOQ SANS data gives an error from the file name parser about the name being longer than the number of buffer spaces.

It does this in 3rd Oct & 16th Oct downloads, but not in the 30 Sept one in my office (else I would send a screen shot).

Richard

Attachments

test_8147.py (847 bytes) - added by Gesner Passos 7 years ago.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Gesner Passos

The problem was introduced after #8055.

I have explained to the user:

Now, I look for files using the FileFinder object. 
It is the default way to do across mantid. 
It is by default casesensitive to speed up finding files across the archiver. 
But, you may change this by configuring the Mantid.user.properties file:

filefinder.casesensitive=Off

The specific error came because, in order to find if the period was defined 
in the input string, in the SANSBatch mode, it changed the string to uppercase 
and tries to find the letter ‘P’. 
Now, I have changed to try to find the letter ‘p’ or  ‘P’ but does not 
change the case of the letters. This specific problem is sorted, but, 
if the users start to misspell the files using different case, it won’t proceed well. 
Last edited 7 years ago by Gesner Passos (previous) (diff)

comment:3 Changed 7 years ago by Gesner Passos

SANS batch mode do not change case letters

re #8147

Changeset: 1e4624aa57c7a6d049fecc3f7710f29e1ea535a2

Changed 7 years ago by Gesner Passos

comment:4 Changed 7 years ago by Gesner Passos

Tester:

run the attached file to check this ticket. The final line must be a 'success'.

comment:5 Changed 7 years ago by Gesner Passos

SANSAdd extend raw types to RAW as well

This allows the summing of .RAW files to load their details.

It was specially necessary to be able to deal with systemtests LOQ values that are .RAW files.

re #8147

Changeset: ed57703c46ad393801ae889a6a81a473f7d1f0fe

comment:6 Changed 7 years ago by Gesner Passos

SystemTest: SANS reduction of added files

re #8147

Changeset: 1a3b6b4fce1d1db1fcf3a9d915df811d0895071b

comment:7 Changed 7 years ago by Gesner Passos

I've added a system test as well to ensure it continue to work correctly.

the branch has the same name of this ticket: 8147_sans_reduction_add_files

Please, remember to push to master the code and the systemtest (if it pass)

comment:8 Changed 7 years ago by Gesner Passos

LOQAddBatch: relax tolerance for Windows

re #8147

Changeset: 308c3b8ac694656509a1afff17428df7c59593b2

comment:9 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:11 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8147_sans_reduction_add_files'

Full changeset: 960f55895c3722c5e772212eb7578cbb46e93a29

comment:12 Changed 7 years ago by Samuel Jackson

Merge remote-tracking branch 'origin/feature/8147_sans_reduction_add_files'

Full changeset: 0f84864a634b18fac565744ce816ce19bb0eeccc

comment:13 Changed 7 years ago by Samuel Jackson

Testing script works, system test passes and the code looks good.

comment:14 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/8147_sans_reduction_add_files'

Full changeset: 3dd3669699ece2d1e42fc8ec922d96e8e7cda687

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8992

Note: See TracTickets for help on using tickets.