Ticket #8247 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IBayes] Unchecked sequential fit option causes error.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.0
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

Un-checking the sequential fit option on both Quasi and Stretch cause an error.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Tester set to Peter Parker

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8247 Fix naming inconsistency on result workspaces.

This is in both QLrun and QuestRun.

Changeset: 69516c4de7a8970a8d358fddefb4085ae2f6bda6

comment:3 Changed 7 years ago by Samuel Jackson

Refs #8247 Updated system tests to account for fix.

Changeset: 7af5cbbec81a35424b1374677df90c1a80b38b51

comment:4 Changed 7 years ago by Samuel Jackson

Refs #8247 Missed grouping output workspace.

Changeset: 3fdb480047b69e00383a9883f7488295c080a731

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying

comment:7 Changed 7 years ago by Samuel Jackson

I've changed both Quasi and Stretch to output to a group workspace regardless of how many iterations of the fit we perform.

To Tester:

Be sure to check the system tests are passing for all Bayes tests. You'll need to push both the main branch and the system tests branch to master. This will need to be built on Windows in Release mode.

Run through both Stretch and Quasi. Deselect the "Sequential fit" option and select "Save Result" for both tabs. You should no longer get an error.

comment:8 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8247_bayes_seq_fit_error'

Full changeset: ​60ce848ce18eb30eeb17790c4bfd3097a4c38042

comment:9 Changed 7 years ago by Peter Parker

Merge remote-tracking branch 'origin/bugfix/8247_bayes_seq_fit_error'

Full changeset: ​b0013c64ec6c6d87bde845c68b51c545312c7004

comment:10 Changed 7 years ago by Peter Parker

System tests passed fine. Both tabs now save results when "Sequential Fit" is unchecked.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9092

Note: See TracTickets for help on using tickets.