Ticket #8306 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Live data: Improve misleading log messages

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: trivial Milestone: Release 3.0
Component: Framework Keywords: LiveData
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

MonitorLiveData outputs a log message when the run ends. It includes the run number. If that is not available it prints 0. This could be confusing, particularly in the case when the user is running the Step Scan GUI as the output TableWorkspace does not contain the run information (so you always get 0).

There's also another log in the SNS listener that really should be a debug one. It shouldn't happen, but it does occasionally - though no harm appears to be done when it does show up.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #8306. Only show a run number if one is available.

Previously, you would see "Run #0 ended" in some situations, when the actual run number was different.

Changeset: fd1dd1d06b06a148f7e3e9f782e4968b33a9b893

comment:2 Changed 7 years ago by Russell Taylor

Re #8306. Reduce log level from warning to debug.

These messages appear sometimes, but are really not useful to the user. They don't appear to signal a significant or externally noticeable problem.

Changeset: dc0a78373f1bc22648718282b5188c5fb2b360f4

comment:3 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test: Start a live data run from HYSPEC or SEQUOIA. Note that whatever "End of Run" option you choose you see a log message starting with "Run #NNNNN ended." at the end of the run. Do the same with the Step Scan GUI and the message you see is "Run ended. Stopping live data monitoring.", with no mention of a run number.

comment:4 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:5 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8306_misleading_log_message'

Full changeset: c5ee3a4a3cd2b18ba1ab79522021abac399c9aa4

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9151

Note: See TracTickets for help on using tickets.