Ticket #8332 (closed: fixed)
Enable LeBailFit and LeBailFunction to support Fullprof polynomial background
| Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Diffraction | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Owen Arnold |
Description (last modified by Wenduo Zhou) (diff)
Fullprof polynomial background (FullprofPolynomial) is implemented recently. The current input properties for background function cannot handle this background function with trivial modification.
Modify the input properties and the method to create background function to support FullprofPolynomial function.
Attachments
Change History
comment:2 Changed 7 years ago by Wenduo Zhou
- Status changed from new to inprogress
Added support to FullprofPolynomial. Refs #8332.
Changeset: b0a9eb79bf03c8b0556f41e868ea082e667ba037
comment:3 Changed 7 years ago by Wenduo Zhou
Fixed a bug in unit test. Refs #8332.
Changeset: a7410f1ddf089f75856c35e07cced8ae8605215b
comment:4 Changed 7 years ago by Wenduo Zhou
Removing white space in read in parameter name. Refs #8332.
Changeset: da31aa165a8534ad0f2f1407abc6f8a63fb915e8
comment:5 Changed 7 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to wontfix
It is closed as 'wontfix' by mistake.
comment:6 Changed 7 years ago by Wenduo Zhou
- Status changed from verify to reopened
- Resolution wontfix deleted
comment:7 Changed 7 years ago by Wenduo Zhou
- Status changed from reopened to verify
- Resolution set to fixed
For testers
- Download all the files attached;
- Run Test8332V.py; Inside this script, you can see ExaminePowderDiffProfile taking 'FullprofPolynomial' as the background type.
- Check the output workspace 'VULCAN_22946_Calculated' to see whether the calculated background makes sense.
comment:8 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:9 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
The script works fine. But I noticed a typo in LeBailFunction.cpp line 943: "Chebysheve" instead of "Chebyshev". Using named constants should prevent this type of error.
It seems that the unit tests don't test background types. Maybe it's in system tests?
comment:10 Changed 7 years ago by Wenduo Zhou
- Status changed from reopened to inprogress
Fixed type. Refs #8332.
- Fixed the reported typo.
- Replace background type string by string constant
Changeset: edcb46b1e94598d599c4a73a9d85866594433283
comment:11 Changed 7 years ago by Wenduo Zhou
Added unit test for background type. Refs #8332.
Changeset: 8d3401ea7bf2f75999aee611eff3110e0d282fbf
comment:12 Changed 7 years ago by Wenduo Zhou
Enabled and fixed 2 unit tests. Refs #8332.
Changeset: 3545f6eb4847b551ec24966dff8c33af98088b7f
comment:13 Changed 7 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:14 Changed 7 years ago by Peter Peterson
- Status changed from verify to reopened
- Resolution fixed deleted
Your string constants on lines 37-39 of LeBailFunction.cpp should be in all caps in accordance with our coding conventions.
comment:16 Changed 7 years ago by Wenduo Zhou
Changed string consts to capitals. Refs #8332.
Changeset: 7c26539c6e56fc19ad8d7547a5a9ba3d6775bcb5
comment:17 Changed 7 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:18 Changed 7 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester changed from Roman Tolchenov to Owen Arnold
comment:19 Changed 7 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8332_lebail_fppoly'
Full changeset: 555234d480d2046af518fe1ddb6a83f747bd2dd8
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9177
