Ticket #8337 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IDA] CalcCorr not working with some inputs.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: critical Milestone: Release 3.0
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

The issue is that the fltabs function isn't always returning something. The return statement at the end needs to be unindented by 1 line.

Attachments

test_fltabs.py​ (375 bytes) - added by Samuel Jackson 7 years ago.
Testing script

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8337 Add system test to check this use case.

Changeset: 3432f39260ea9881bbc56bfcdb1142d18255f229

comment:2 Changed 7 years ago by Samuel Jackson

Refs #8337 Return statement now correctly aligned.

Changeset: 531154c987cf765ea8ef0ed08ee5ee3d2bba3f7a

comment:3 Changed 7 years ago by Samuel Jackson

Merge branch 'bugfix/8337_fltabs_error_some_inputs' into develop

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectAbsCor.py

Refs #8337

Changeset: 3ed21eec1a7469f53b04dd00df0a316ecc729b3d

comment:4 Changed 7 years ago by Samuel Jackson

I corrected the offending line and added a system test to check in case this issue ever creeps back.

To Tester

Check the code changes are appropriate and the system tests are passing. I've also provided a python script based off the added system test which can be used for testing.

Changed 7 years ago by Samuel Jackson

Testing script

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

System tests were broken by another ticket. This should now have been fixed.

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8337_fltabs_error_some_inputs'

Full changeset: ​c80aeebd85a9dc5f315e60a9636ea2b9273a8404

comment:8 Changed 7 years ago by Nick Draper

tested with another file, and code review (just a tab really)

comment:9 Changed 7 years ago by Nick Draper

Merge remote-tracking branch 'origin/bugfix/8337_fltabs_error_some_inputs'

Full changeset: ​ba54ae5706146284c18e3e19f3d2801ae512b9ca

comment:10 Changed 7 years ago by Samuel Jackson

Refs #8337 Add system test to check this use case.

Changeset: 4819c8b8e69d094c718149d7e9c9efa8471f390b

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9182

Note: See TracTickets for help on using tickets.