Ticket #8346 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IndirectDiff] OSIRIS Diffraction: Merging two files that are the same

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.1
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description (last modified by Samuel Jackson) (diff)

Reported by Franz. Because we automatically correct for merging overlapping ranges when we sum two files that are the same we get an output that is incorrect. We instead should check if the runs are identical and if so, not scale them.

Attachments

OSI_DiffTest.py (260 bytes) - added by Samuel Jackson 7 years ago.
Testing script
osiris00102569.raw (1.5 MB) - added by Samuel Jackson 7 years ago.
File for testing.
osiris00102570.raw (1.5 MB) - added by Samuel Jackson 7 years ago.
File for testing.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8346 Change workspace averaging to only use unique names.

Changeset: 50bbba148a8931d08af7ad3de7b57961962957c2

comment:2 Changed 7 years ago by Samuel Jackson

The problem was with averaging the runs. I changed the code so that averaging only considers unique workspace names.

To Test:

Check that you get the same result when inputting two files that are the run. I've provided a test script that can be used to run OSIRIS diffraction using files from the system tests.

Last edited 7 years ago by Samuel Jackson (previous) (diff)

comment:3 Changed 7 years ago by Samuel Jackson

  • Description modified (diff)

comment:4 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.1

comment:6 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:7 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Refs #8346 Implement better way of filtering of runs.

Changeset: d1a17c4d6f9af60b801e820dbf5d89eb656a5843

comment:8 Changed 7 years ago by Samuel Jackson

Refs #8346 Check if d-range between files matches exactly.

Changeset: 8e2fbe6ac255e589579aba73682d6eb7d1ca5c4e

Changed 7 years ago by Samuel Jackson

Testing script

Changed 7 years ago by Samuel Jackson

File for testing.

Changed 7 years ago by Samuel Jackson

File for testing.

comment:9 Changed 7 years ago by Samuel Jackson

To Tester

Use the script provided, run OSIRISDiffractionReduction with the provided runs. The calibration file and Vanadium files can both be found in the system tests data folder. The algorithm should now only use one copy of runs with exactly the same x values.

comment:10 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:12 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Ran the script on Mantid with and without the changes. The results with the changes are twice as big as ones without the changes. I assume that this is what is expected.

comment:13 Changed 7 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/bugfix/8346_OSIRIS_diff_merging'

Full changeset: 1c5994dca276eb43f65da0f8fb8b7f2168768a6d

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9191

Note: See TracTickets for help on using tickets.