Ticket #8347 (closed: fixed)
[IBayes] Upgrade JumpFit
Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | spencer.howells@… | Blocked By: | #8585 |
Blocking: | Tester: | Roman Tolchenov |
Description
There's a couple of additional fit functions that could be useful in JumpFit, namely:
- Fick's Law
- Teixeira
It also might be an idea to add the ability to define a custom function.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
- Status changed from new to inprogress
Refs #8347 Add new python fit function options for JumpFit
Changeset: 64b6852158b3a41a239735c461ea1743dcac1621
comment:3 Changed 7 years ago by Samuel Jackson
Refs #8347 Modifying Indirect JumpFit to support new functions.
Changeset: 71369d3f1dd0b03e103eb347022c5f0e82a792a6
comment:4 Changed 7 years ago by Samuel Jackson
Refs #8347 Update Bayes interface to support new functions.
Changeset: 10b0dbf20f6860df9ff87afa9204dda2135a286a
comment:5 Changed 7 years ago by Samuel Jackson
Refs #8347 Correct variable name.
Changeset: fcafaac11d8f7961c79a3ee9e3685595ed70668d
comment:6 Changed 7 years ago by Samuel Jackson
Refs #8347 Refactor functions to use Numpy functions where possible.
Changeset: fca13a672975877740b8a768ec501444bc3884af
comment:7 Changed 7 years ago by Samuel Jackson
Refs #8347 Minor tweaks to IndirectJumpFit.
Changeset: 41c24d41b1e3b790822b3047cba084e07e7e6686
comment:8 Changed 7 years ago by Samuel Jackson
Refs #8347 Updated system tests and reference results.
Changeset: 708cc125d13d8842a0ab8aded42871b10f210087
comment:10 Changed 7 years ago by Samuel Jackson
Refs #8347 Up system test tolerance.
The errors on the this particular fit are quite high, but the values themselves are fairly consistent.
Changeset: b01bc9518b67236e459326ec1c5b606973d2c239
comment:11 Changed 7 years ago by Samuel Jackson
Refs #8347 Remove unneeded clean up code.
This code was used to clean up files created by the old Fortran implementation. It is no longer required in our pure Mantid implementation.
Changeset: eac78425b3dc876922d135f98d3093e2bd90ca34
comment:12 Changed 7 years ago by Samuel Jackson
Refs #8347 Updated Bayes system tests with a more sensible run.
Changeset: 1013828ed89e269770a854f816e8471dc3916b84
comment:13 Changed 7 years ago by Samuel Jackson
To Tester
Two new fit functions have been added to JumpFit. Also, the existing options have been moved to python implemented fit functions, hence you will need to test all four.
First generate a workspace that can be used with JumpFit. The easiest way to do this is to run a sequential ConvFit as described on the wiki:
http://www.mantidproject.org/Indirect:Indirect_Data_Analysis#Running_ConvFit
Use the *_Workspace generated by ConvFit as input to JumpFit and test that executing each fit function produces sensible output.
Additionally, check that each of the fit functions listed in JumpFit are also accessible in the fit browser and produce similar output to the JumpFit interface.
This ticket will need merging in both the main repo and the system tests
comment:14 Changed 7 years ago by Samuel Jackson
- Blocked By 8585 added
It would be best to test and merge #8585 before this testing ticket as changes have been made to both Quasi, ConvFit and JumpFit that could effect this ticket.
comment:15 Changed 7 years ago by Samuel Jackson
Refs #8347 Move cropping x-range to Fit algorithm.
Changeset: 0ea5bd90052e02511492c491179313011f841470
comment:16 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:17 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:18 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8347_upgrade_jumpfit'
Full changeset: 1a63178b1440346f47a74a29d2092bcef756b7b0
comment:19 Changed 7 years ago by Roman Tolchenov
Merge remote-tracking branch 'origin/feature/8347_upgrade_jumpfit'
Full changeset: 7f3c9e7259339a197229a697ef8e372f0ce2355b
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9192