Ticket #8382 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Clear up CPPcheck warnings

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.1
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description


Change History

comment:1 Changed 7 years ago by Nick Draper

  • Owner changed from Nick Draper to Wenduo Zhou

comment:2 Changed 7 years ago by Nick Draper

  • Owner changed from Wenduo Zhou to Nick Draper

Sorry, reassigned the wrong ticket

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to inprogress

re #8382 reduce cppcheck warnings

Changeset: b7e0a55f9a4c0ed2b3189f9082e8fe823930c8ea

comment:4 Changed 7 years ago by Nick Draper

re #8382 remove failure with Progress ambiguity

Changeset: 73d314caeb9b34d918a81201f0b28ea7dbb19ba7

comment:5 Changed 7 years ago by Nick Draper

re #8382 remove failure with Progress ambiguity

Changeset: 39e1dff4a45d86c7fbb22351a5b772634c2f386e

comment:6 Changed 7 years ago by Nick Draper

re #8382 remove warning

Changeset: bd6f8719d1c4fab748b7eaa4cff4d1699db0219e

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester:

  1. test by code review
  2. check build server warnings, unit tests and system tests
  3. After merging the number of cppcheck warning level errors should decrease

comment:8 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:9 Changed 7 years ago by Russell Taylor

Re #8382. Move suppression to the right place.

Changeset: 3b01b518041dbe5c4be3db6c15f0b94a024ff250

comment:10 Changed 7 years ago by Russell Taylor

Re #8382. Don't explicitly specify default constructors for UDT's.

If member is not a POD-type, specifying member() will invoke the type's default constructor. In principle, explicitly calling the default constructor, i.e. member(Constructor()), will construct a temporary and then call the copy-constructor. At minimum it's redundant typing.

Changeset: e749db77808b1fb6d863f7b4d2bbc137df40e36d

comment:11 Changed 7 years ago by Russell Taylor

Re #8382. Move suppression to the right place.

Changeset: 6bde8af52a40fc4da331f7e090475c2eb8ed200b

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8382_cppcheck_warnings'

Full changeset: ​85f8e831114aac1c273a582c8ca6da016215d30a

comment:13 Changed 7 years ago by Russell Taylor

The suppressions on DataPointMarker & ImageMarker didn't work, but it looks like those classes (or the base class) aren't used anyway - #8463 created to check.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9227

Note: See TracTickets for help on using tickets.