Ticket #8463 (closed: fixed)
MantidPlot classes DataPointMarker & perhaps PlotEnrichement appear to be unused
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | trivial | Milestone: | Release 3.1 |
| Component: | GUI | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description
Check whether this is definitely the case, and if so remove them.
Change History
comment:2 Changed 7 years ago by Russell Taylor
Re #8463. Remove unused PlotEnrichement class.
It was a base to the ArrowMarker & ImageMarker classes, but was not doing anything. The only place it was specifically mentioned, it was calling a virtual method on an instance of one of those base classes that is overridden in those classes.
Changeset: c447dd600737a3dcc0890c183f870a80142e2352
comment:3 Changed 7 years ago by Russell Taylor
Re #8463. Remove unused DataPointMarker class.
Changeset: 2bad1ca6b71429c8e77fd9d2417446044558a3df
comment:4 Changed 7 years ago by Russell Taylor
Re #8463. Remove unused PlotEnrichement class.
It was a base to the ArrowMarker & ImageMarker classes, but was not doing anything. The only place it was specifically mentioned, it was calling a virtual method on an instance of one of those base classes that is overridden in those classes.
Changeset: daf5f50ce8903f9ea1d4e83cc29c348566ee5b5a
comment:5 Changed 7 years ago by Russell Taylor
Re #8463. Remove now-redundant cppcheck suppression statements.
Changeset: c42401128bd47d8b31873ae95bce8f1e15d90f70
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Tester: Branch is feature/8463_remove_unused_classes
Mainly test by inspection to observe that the removed code was not being used anyway. Have a quick play around to make sure adding arrows and images to plots (under the Graph menu) works.
comment:7 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:8 Changed 7 years ago by Martyn Gigg
Confirmed that the classes were indeed unused and that the used member was simply calling the base class.
All of the adding methods still work as expected.
comment:9 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8463_remove_unused_classes'
Full changeset: 321a5178f18d5e171322d310d8e20c14165a88d1
comment:10 Changed 7 years ago by Russell Taylor
Re #8463. Remove unused DataPointMarker class.
Changeset: 162876adb7e9b59a8879b0a5621db4e7eabbaf7f
comment:11 Changed 7 years ago by Russell Taylor
Re #8463. Remove unused PlotEnrichement class.
It was a base to the ArrowMarker & ImageMarker classes, but was not doing anything. The only place it was specifically mentioned, it was calling a virtual method on an instance of one of those base classes that is overridden in those classes.
Changeset: c447dd600737a3dcc0890c183f870a80142e2352
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9307
Re #8463. Remove unused DataPointMarker class.
Changeset: 162876adb7e9b59a8879b0a5621db4e7eabbaf7f