Ticket #8385 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Reduce the compiler warnings

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Keith Brown

Description

Take a look at the compiler warnings and try to drop them back to zero.

​http://download.mantidproject.org/jenkins/view/Develop%20Clean%20Builds%20and%20Tests/job/is_clean_win7_develop_db/

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8385 Remove unsued variable from SortPeaksWorkspace

Changeset: d260b12948b03ec4186143712c71398e89cdb430

comment:2 Changed 7 years ago by Samuel Jackson

Refs #8385 Remove unused variable from LoadIDFFromNexus

Changeset: b79b1eb44993fe6e73f941fcbc7f5e3b3e046d2e

comment:3 Changed 7 years ago by Samuel Jackson

Refs #8385 Swap variable type to size_t

Changeset: 9b12017a34e5ba72f7960d1c31305696962ea3a6

comment:4 Changed 7 years ago by Samuel Jackson

Refs #8385 Change type of variable in FileDescriptorTest

Changeset: dddf45a9b17c36676ed2aa4a155005eec28bb47d

comment:5 Changed 7 years ago by Samuel Jackson

Refs #8385 Remove unused variable in QueryAllRemoteJobs

Changeset: 382bd9085751755b7e6d6434620a6927e2bda759

comment:6 Changed 7 years ago by Samuel Jackson

Refs #8385 Change type of variable in PoldiRemoveDeadWires

Changeset: 09ad6ca09c2067b4baa7097534df864e5e52cbfb

comment:7 Changed 7 years ago by Samuel Jackson

Refs #8385 Add cast to variable in InvertMDDimTest

Changeset: 6e6cdecf07b9d9f0c265cec408e073f1b2d23e1d

comment:8 Changed 7 years ago by Samuel Jackson

Refs #8385 Add static cast to variable in LoadFlexiNexusTest

Changeset: 8f3e6a17fdcf9216445baa52bcdfbf6b5b966e7e

comment:9 Changed 7 years ago by Samuel Jackson

Refs #8385 Fix warnings in ProjectMDTest

Changeset: 969ffa1163fce4342bc8bc0bb81739cc20c8a3ef

comment:10 Changed 7 years ago by Samuel Jackson

Refs #8385 Add cast to variable in SliceMDHistoTest

Changeset: dcdccd4f1d179e5fda081db71a9a8b2f84e5b63a

comment:11 Changed 7 years ago by Samuel Jackson

Refs #8385 Add cast to variables in IO_MuonGrouping

Changeset: 09587db533ff86b88d56a5e26aa8382a65726c7e

comment:12 Changed 7 years ago by Samuel Jackson

Refs #8385 cast variable to correct type.

Changeset: 028d236c501ae34cf31d54a4558dba245dcce3b5

comment:13 Changed 7 years ago by Samuel Jackson

Refs #8385 Cast variable to correct type.

Changeset: b4d6ac1af06446adcd4f9cce189c31810dab361c

comment:14 Changed 7 years ago by Samuel Jackson

Refs #8385 Swap default range to within the bounds of a float.

Changeset: 55c0a0467a111bffa560cf36db45b8326d279810

comment:15 Changed 7 years ago by Samuel Jackson

Refs #8385 Cast variable to the correct type.

Changeset: 49edbc5287f905b6fb6d9d0264674bbd76464b4c

comment:16 Changed 7 years ago by Samuel Jackson

Refs #8385 Cast variable to correct type.

Changeset: 0c841fb3129321cb50db6c3e331692e2de37616d

comment:17 Changed 7 years ago by Samuel Jackson

Refs #8385 Undo commit to fix build servers for now.

Changeset: d37882b197518e4f896db17850c22d62a53abaeb

comment:18 Changed 7 years ago by Samuel Jackson

Refs #8385 Refactor code to sum spectra.

Changeset: 258dfb83e531b1e507a3c4f92d708d2959431ce2

comment:19 Changed 7 years ago by Samuel Jackson

I've dropped all the warnings on the windows build back down apart from a few complaints with linking in some of the test projects. I've created ticket #8408 to deal with these separately.

To Tester

Check the warnings (except the ones mentioned above) are gone from the build servers:

​http://download.mantidproject.org/jenkins/view/Develop%20Clean%20Builds%20and%20Tests/job/is_clean_win7_develop_db/

Also do a code inspection to check the changes are appropriate.

Last edited 7 years ago by Samuel Jackson (previous) (diff)

comment:20 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Tester set to Keith Brown

comment:21 Changed 7 years ago by Keith Brown

  • Status changed from verify to verifying

comment:22 Changed 7 years ago by Keith Brown

Code looks fine, only warnings remaining are those at will be dealt with separatly.

Also built locally to check warnings and had the same result.

comment:23 Changed 7 years ago by Keith Brown

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8385_compiler_warnings'

Full changeset: ​0bf03348a5e51c8404e6ceabf0cee15b83da5c7f

comment:24 Changed 7 years ago by Peter Peterson

  • Milestone changed from Backlog to Release 3.1

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9230

Note: See TracTickets for help on using tickets.