Ticket #8408 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix warnings in Win7 test projects

Reported by: Samuel Jackson Owned by: Martyn Gigg
Priority: minor Milestone: Release 3.1
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

The windows 7 build is showing the following warnings for some of the test projects:

defaultlib 'MSVCRT' conflicts with use of other libs;
 use /NODEFAULTLIB:library [C:\jenkins\workspace\is_clean_win7_develop_db\build\Framework\Geometry\test\GeometryTest.vcxproj]

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Keywords Maintenance added
  • Milestone changed from Backlog to Release 3.1

comment:2 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress

comment:3 Changed 7 years ago by Martyn Gigg

This appears to be occur when linking to gmock/gtest. Those projects are linked to the release runtime in debug.

comment:5 Changed 7 years ago by Martyn Gigg

Kill /NODEFAULTLIB warnings when compiling tests under MSVC in debug

They were caused by gtest/gmock statically linking to the release runtime in debug mode. The fix has required patching gmock/CMakeLists & gtest/CMakeLists to remove hard-coded /MD switch. This patch has already been incorporated in to gmock 1.7.0 but we cannot upgrade since this does not compile with the std=c++0x flag on gcc. Refs #8408

Changeset: 92a54f5d7435ede38840afcbae82c2a3575c4559

comment:6 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: bugfix/8408_fix_msvc_linker_warnings

Tester: Look here. There were eight warnings about linker errors that mentioned the phrase /NODEFAULTLIB. These should now be gone. Similary building in debug a local copy on Windows should not produce this warning.

comment:7 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:7 Changed 7 years ago by Martyn Gigg

  • Status changed from reopened to inprogress

Make sure gtest doesn't overwrite flags that are already set.

Refs #8408

Changeset: 178a42ee1e40edd7d8f3921293cec0c467d1dee4

comment:8 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:9 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:10 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8408_fix_msvc_linker_warnings'

Full changeset: 0696ddc799f469896cfd84feaea4f3f27511c6a5

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9253

Note: See TracTickets for help on using tickets.