Ticket #8402 (closed: fixed)
LoadFullprofResolution: params added on spectrum by spectrum basis
| Reported by: | Anders Markvardsen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Diffraction | Keywords: | |
| Cc: | zhouw@… | Blocked By: | #8705 |
| Blocking: | #8404 | Tester: | Wenduo Zhou |
Description
At this point still ignore the Banks parameter.
When Workspace is specified:
- check that the number of spectra in the workspace equals the number of banks in the .irf file
- If they are not equal output a warning along the lines of: "Number of spectra not equal to number of banks in Fullprof instrument file. Instrument parameters not applied to workspace"
- If they are equal then apply the fullprof instrument parameters to the spectra
Attachments
Change History
comment:4 Changed 7 years ago by Karl Palmen
From discussion with Anders, it emerged that the workspace would be a grouped workspace with one spectrum per single workspace.
The Workspace property of LoadFullprofResolution must refer to such a workspace. Ticket #8705 needs fixing to ensure a single (not grouped) Table workspace would be produced for OutputTableWorekspace.
Then the parameters of the first fullprof bank be applied to the first workspace in the group, the parameters of the second fullprof bank to the second workspace etc. Conditions 1. and 2. would be imposed for this.
For each workspace in the group, the parameters can be applied to the whole instrument, banks will no longer matter.
Unit test will need modifying to reflect this.
comment:5 Changed 7 years ago by Karl Palmen
Make necessary changes re #8402
Unit test needs extending to test these changes.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: b2f850a11c8e6a3ae00c5ee362ce55318a94b181
comment:6 Changed 7 years ago by Karl Palmen
Add unit test to test multiple workspace re #8402
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 81c19c2beeb3d5fa965f6f98cb15156c67b8b209
comment:7 Changed 7 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
comment:8 Changed 7 years ago by Karl Palmen
To test I suggest running LoadFullprofResolution with the recently attached files or similar.
Also check that the unit test is correct and adequate.
comment:9 Changed 7 years ago by Karl Palmen
Also test that appropriate error message occurs if the number of workspaces does not match the number of banks. This can be done via the banks property or by trimming a bank from the .irf file.
comment:10 Changed 7 years ago by Karl Palmen
- Status changed from verify to reopened
- Resolution fixed deleted
I have an unused variable to remove from the unit test.
comment:11 Changed 7 years ago by Karl Palmen
- Status changed from reopened to inprogress
Remove unused variable re #8402
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d18d8c1b8414555649ede128b69e2cc22dbc116f
comment:12 Changed 7 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
comment:13 Changed 7 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:14 Changed 7 years ago by Wenduo Zhou
It works as requested.
comment:15 Changed 7 years ago by Wenduo Zhou
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8402_bank_to_workspace'
Full changeset: 3a43141f23d5a7dc14850d473096260bb9036e66
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9247
