Ticket #8705 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

LoadFullprofResolution to produce One Table Workspace for Grouped Workspace

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: #8402 Tester: Anders Markvardsen

Description

Ticket #8398 enabled fullprof data to be transferred to the instrument parameters of a matrix workpace. It has been found that if this workspace is a grouped workspace and outputTableWorkspace is set. The outputTableWorkspace is a grouped workspace of identical tables.

This ticket is to make OutputTableWorkspace one table as an non-grouped TableWorkspace even if Workspace is a grouped workspace.

Attachments

GEM63437_integrated.nxs​ (610.0 KB) - added by Karl Palmen 7 years ago.
small GEM file for workspace group

Change History

comment:1 Changed 7 years ago by Karl Palmen

  • Milestone changed from Backlog to Release 3.1

comment:2 Changed 7 years ago by Karl Palmen

  • Status changed from new to inprogress
  • Owner set to Karl Palmen

comment:3 Changed 7 years ago by Karl Palmen

If ran with OutputTableWorkspace not set, one gets "Error in execution of algorithm LoadFullprofResolution Add object with empty name". This too needs fixing.

Last edited 7 years ago by Karl Palmen (previous) (diff)

comment:4 Changed 7 years ago by Karl Palmen

To access the group structure, the workspace property needs to be a WorkspaceGroup rather than a Workspace (as in the UngroupWorkspace algorithm). This would also be useful for #8402. We'd have already forced the workspace to be a group.

comment:5 Changed 7 years ago by Karl Palmen

Fix and modify unit test re #8705

This fix has removed the capability to handle a non-grouped workspace, but this capability is not needed. The change prepares the code for #8402 .

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 73d28eb9547d027f48ba82c184966ae423318ae9

comment:6 Changed 7 years ago by Karl Palmen

Update documentation and tidy up re #8705

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0fc5ea7c1c9fe3eec1172b27b3c62ca00718bc5b

Changed 7 years ago by Karl Palmen

small GEM file for workspace group

comment:7 Changed 7 years ago by Karl Palmen

To test, load a workspace from a GEM file such as the one attached that has a workspace group of several GEM workspaces. Run LoadFullprofResolution with various output options. When OutputTableWorkspace is selected check that it produces one workspace and it is well formed.

Also check that the unit test is correct and adequate.

comment:8 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:9 Changed 7 years ago by Karl Palmen

The modification of parameters only occurs for the first workspace of the group. It will be extended to others in the course of fixing #8402.

comment:10 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:11 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8705_one_table'

Full changeset: ​139cbb053c77420a5cb5b9164cd5ca4fae422619

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9549

Note: See TracTickets for help on using tickets.