Ticket #8436 (closed: fixed)
Rename HWHM parameter of Lorentzian to FWHM
| Reported by: | Roman Tolchenov | Owned by: | Roman Tolchenov |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Samuel Jackson |
Description
Change History
comment:2 Changed 7 years ago by Roman Tolchenov
Re #8436. Corrected ConvFit page.
Changeset: 7d0e6ff12fdf9685c183325450aff1530d9d4342
comment:3 Changed 7 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
comment:4 Changed 7 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:5 Changed 7 years ago by Karl Palmen
I ran Mantid before running the git macros for this test and found the HWHM parameter when about to fit Lorentzian.
comment:6 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
Franz reported a crash when using ConvFit with the renamed parameter
comment:7 Changed 7 years ago by Roman Tolchenov
- Status changed from reopened to inprogress
Re #8436. Refactored RangeSelector to prevent signal loops.
Changeset: 3c42712886a60c3362c79a89c3f863ba5aef15c1
comment:8 Changed 7 years ago by Roman Tolchenov
Re #8436. Renamed HWHWM to FWHM in Lorentzian.
Changeset: 2bb3ada1bbddf3edd74caefc9d737d6ff7d35250
comment:9 Changed 7 years ago by Roman Tolchenov
Re #8436. Corrected ConvFit page.
Changeset: 20dcf9064ab280ed4ef6edc946c22fd886036c24
comment:10 Changed 7 years ago by Roman Tolchenov
Re #8436. Refactored RangeSelector to prevent signal loops.
Changeset: 4f8cdb4bf1dbfbfbb1c9896a7fdb3aae71f61bad
comment:11 Changed 7 years ago by Roman Tolchenov
Re #8436. Update range selector on ConvFit when peak centre moves.
Changeset: 0790145cd63d5d90c05b317c24b95a36a3619cb8
comment:12 Changed 7 years ago by Roman Tolchenov
Merge branch 'feature/8436_rename_Lorentzian_HWHM_to_FWHM' into develop
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/ConvFit.cpp
Re #8436.
Changeset: 22bcdcb32282c7120f3dccb0ceb65bca3d1a8045
comment:13 Changed 7 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
comment:15 Changed 7 years ago by Karl Palmen
- Status changed from verifying to verify
- Tester Karl Palmen deleted
Test works OK, for Lorentzian fitting, but I found out I don't know how to use IDA for Convfit, so I'm returning it to the testing pool for that.
comment:16 Changed 7 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester set to Samuel Jackson
comment:17 Changed 7 years ago by Samuel Jackson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8436_rename_Lorentzian_HWHM_to_FWHM'
Full changeset: b257be7f328910c783b318e9e929849776640b71
comment:18 Changed 7 years ago by Roman Tolchenov
Re #8436. Renamed HWHWM to FWHM in Lorentzian.
Changeset: 1efacc7cc915f6090c91025f0215f888b53f7e26
comment:19 Changed 7 years ago by Roman Tolchenov
Re #8436. Corrected ConvFit page.
Changeset: 7d0e6ff12fdf9685c183325450aff1530d9d4342
comment:20 Changed 7 years ago by Roman Tolchenov
Merge branch 'feature/8436_rename_Lorentzian_HWHM_to_FWHM' into develop
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/ConvFit.cpp
Re #8436.
Changeset: 22bcdcb32282c7120f3dccb0ceb65bca3d1a8045
comment:21 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9280
Re #8436. Renamed HWHWM to FWHM in Lorentzian.
Changeset: 1efacc7cc915f6090c91025f0215f888b53f7e26