Ticket #8438 (closed: fixed)
SANS change the way reduction deals with log
| Reported by: | Gesner Passos | Owned by: | Gesner Passos |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | SANS | Keywords: | |
| Cc: | peter.parker@… | Blocked By: | #8395 |
| Blocking: | #8435 | Tester: | Anders Markvardsen |
Description
There are many parts of the reduction in sans that keeps track of the 'logs' which is used only for sample and can and for SANS2D instrument only.
Besides, the signature of AssignCan, AssignSample returns a reference to this 'logs'.
There is no point of having it. Get rid of it. Move this specific processing to the isis_instrument.py file.
Change History
comment:1 Changed 7 years ago by Gesner Passos
- Status changed from new to inprogress
- Blocked By 8395 added
comment:3 Changed 7 years ago by Gesner Passos
re #8438: Make SANS GUI and SANS Batch independent from logs
The Sans GUI interface does not depend any more of returning the logs from AssignSample or AssignCan. These two method should not return such 'obscure' information, but, being the ISISCmdInterface we can not change now.
Changeset: d348aea1a99f6e5ca8b5ced1288da8265e27078d
comment:4 Changed 7 years ago by Gesner Passos
re #8438: Deal with the logs inside isis_instrument for SANS2D
It now uses the log only where it is important, inside the SANS2D instrument.
Changeset: 6d4b49d2e2e0d9f33accfe39698c6860e29191a9
comment:5 Changed 7 years ago by Gesner Passos
re #8438: Remove never called method from isis_instrument::LOQ
Changeset: f3bd22cb01ad1fdb40ad455b99e61e62ce3c3706
comment:6 Changed 7 years ago by Gesner Passos
Tester:
This commit is part of a group of tickets whose final goal is to be able to insert requirements that will be necessary for LARMOR and SANS2D instrument operating in event mode, you may want to follow the blocked tickets to see how this is planned.
The systemtests ensure the functionality does not changed. But, there are steps in the Gui to be checked as well.
- Open SANS interface
- Select SANS2D instrument
- Load systemtests/Data/SANS2D/MaskSANS2DReductionGUI.txt
- type 22048 inside the sample
- change to geometry tab
- You will see some numbers inside SANS2D Geometry block. rear-detector X, Y and fron-detector X, Z, Rot.
- These numbers MUST be the same as the one produced by previous mantid version.
- Type 22023 inside the can and you will see more numbers in the geometry tab, again, it must be the same as previously (except that 0.0 is also equals to the blank from previous code (rotation of 0.0 angle is the same as doing nothing)).
comment:7 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
comment:8 Changed 7 years ago by Gesner Passos
- Status changed from verify to reopened
- Resolution fixed deleted
comment:9 Changed 7 years ago by Gesner Passos
- Status changed from reopened to inprogress
re #8438: Correct on_load_sample method.
Changeset: 72cf6cfefb14fd3a555dd52ebaae8579f21580c8
comment:10 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
comment:11 Changed 7 years ago by Gesner Passos
re #8438: Correct on_load_sample method.
Changeset: 0e5b920454a66ebdcc845b50dda814a3d2f12ec0
comment:12 Changed 7 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:14 Changed 7 years ago by Anders Markvardsen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8438_change_logs_over_larmor'
Full changeset: 1d2c876f572990d40f6a3d5603b5642074849d24
comment:15 Changed 7 years ago by Anders Markvardsen
Systemtest pass and steps in gui worked
comment:16 Changed 7 years ago by Gesner Passos
Merge branch 'feature/8438_change_logs_over_larmor' into feature/8435_redesign_load_data
Full changeset: 6cd69e398d02a44a02bc0bd9039e36cdbf602804
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9282
