[ICAT] Removed unused try/catch from specific algorithms

[Jay Rainey]

When tested #6512 Roman noted:

Algorithms CatalogListInstruments, CatalogListInvestigationTypes, CatalogMyDataSearch catch all runtime errors and throw another one with the same message "Please login..." regardless of the cause of the caught exception and discarding its message. I think the exceptions need to be differentiated here, for example have a specialized LoginError.

This is true as these algorithms were previously used to test if the user was ​authenticated.

Once the inappropriate (logout, & search) are hidden until a user is logged in then this mechanism of authentication can be removed. Therefore, the try/catch used for this purpose from the following three algorithms will have to be removed:

• CatalogListInstruments
• CatalogListInvestigationTypes
• CatalogMyDataSearch

The methods that make use of this logic will also have to be removed. They are:

ICatHelper->validSession()
ICatHelper->openLoginDialog()

[Jay Rainey]

Removed unnecessary try/catch from catalog algors. Refs #8445.

• The try/catch is no longer needed as we should not use these algorithms as a means of checking whether a user is logged in. Instead we have enabled/disabled the appropriate menus in another ticket.

Changeset: bfbd93932b7b090af3f8700ad23ffdb2e11171e0

[Jay Rainey]

Removed methods that are no longer needed. Refs #8445.

Changeset: d87549d6c6f2c335765766c6bb1a5ecfa467620d

[Jay Rainey]

Merge branch 'feature/8445_icat_refactor_algorithms' into develop. Refs #8445.

Conflicts:

• Code/Mantid/MantidQt/MantidWidgets/inc/MantidQtMantidWidgets/CatalogHelper.h

Changeset: 13e0a14903355cee374c854dbc7473d5f38ca76d

[Jay Rainey]

Tidy algorithms. Refs #8445.

• Used auto when possible for cleaner code.
• As most of the algorithms only make use of the catalog to invoke a specific method I now do this directly rather than in two steps.

Changeset: 870e791d8f4777e6b269faf6674df82e71556b2c

[Jay Rainey]

Merge branch 'feature/8445_icat_refactor_algorithms' into develop. Refs #8445.

Conflicts:

• Code/Mantid/Framework/ICat/src/CatalogSearch.cpp

Changeset: 3c37d84e5c669dd7b3e82fbde2249d09a66d02e2

[Jay Rainey]

This ticket should only be tested once #8192 is tested.

To test

1. Log into the catalog within Mantid ensuring that my code changes did not break any functionality.
2. Perform a code review ensuring the changes I made are sensible and correct.

[Jay Rainey]

Merge remote-tracking branch 'origin/master' into feature/8445_icat_refactor_algorithms. Refs #8445

Conflicts:

• Code/Mantid/Framework/ICat/src/CatalogLogin.cpp
• Code/Mantid/MantidQt/MantidWidgets/inc/MantidQtMantidWidgets/CatalogHelper.h

Changeset: e7ad498e1a7622f457e1a790daa16643db4d6e41

[Samuel Jackson]

Merge remote-tracking branch 'origin/feature/8445_icat_refactor_algorithms'

Full changeset: ​c99203692c50a2d1b5f8c000ffbedacc3664d799

[Jay Rainey]

Merge branch 'feature/8445_icat_refactor_algorithms' into develop. Refs #8445.

Conflicts:

Code/Mantid/MantidQt/MantidWidgets/inc/MantidQtMantidWidgets/CatalogHelper.h

Changeset: 13e0a14903355cee374c854dbc7473d5f38ca76d

[Jay Rainey]

Tidy algorithms. Refs #8445.

• Used auto when possible for cleaner code.
• As most of the algorithms only make use of the catalog to invoke a specific method I now do this directly rather than in two steps.

Changeset: 28157ce92e614754c742b558ddd8c27c4c1b9dd7

[Jay Rainey]

Merge branch 'feature/8445_icat_refactor_algorithms' into develop. Refs #8445.

Conflicts:

• Code/Mantid/Framework/ICat/src/CatalogSearch.cpp

Changeset: 3c37d84e5c669dd7b3e82fbde2249d09a66d02e2

[Stuart Campbell]

This ticket has been transferred to github issue ​9289