Ticket #8455 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Correct SampleGeomCor to not use protected members of ISISReducer

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.1
Component: SANS Keywords:
Cc: peter.parker@… Blocked By: #8443
Blocking: Tester: Peter Parker

Description

Currently it gets access to _sample_run. But SampleGeomCor should not know about it, it is a protected member. The pacth attached should address the case, but can not be aplied before #8443

Attachments

patch_for_sans_reduction_steps.patch​ (3.2 KB) - added by Gesner Passos 7 years ago.

Change History

Changed 7 years ago by Gesner Passos

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

re #8455: SampleGeomCor uses only public methods from isis_reducer

Code improvement. It does not use the protected attribute _sample_run, but only public methods. Besides, it does not calculate twice the same value for volume, using the value calculated already.

Changeset: 4a28c1847b6cda18442fdb4b05be4b44953fb968

comment:2 Changed 7 years ago by Gesner Passos

Tester:

All the reductions of SANS2D and LOQ use the code that was touched here. Errors would have been shown in the systemtests. Hence, I think a code review is sufficient here. But, if your consciousness does not let you do just this, you may want to follow instructions in this ​link that will exercise this code as well. Besides check the comments on #8435 to understand why this code was not introduced there.

comment:3 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Milestone changed from Backlog to Release 3.1

comment:4 Changed 7 years ago by Gesner Passos

  • Cc peter.parker@… added

comment:5 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:6 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8455_correct_sample_geom_cor'

Full changeset: ​9e1654758947ccbebd6ff7653778d96440e33dcf

comment:7 Changed 7 years ago by Gesner Passos

Merge branch 'feature/8455_correct_sample_geom_cor' into feature/8444_multiperiod_data

Full changeset: ​6f8718ca5ee03699bbfb15f07ae0a34f77252def

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9299

Note: See TracTickets for help on using tickets.