Ticket #8456 (closed: fixed)
Change overwrite behaviour of LoadDialog when user has specified a default output WS name
Reported by: | Peter Parker | Owned by: | Federico M Pouzols |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Dan Nixon |
Description
Run the following in the Python script window:
LoadDialog("MAR11001.raw", OutputWorkspace="SomeSuggestedWsName", Enable="Filename,OutputWorkspace")
The user's suggested default for the OutputWorkspace name is automatically overridden by the dialog to be "MAR11001". Ideally, if the user has specified a default then we should be using it.
Change History
comment:3 Changed 6 years ago by Federico Montesino Pouzols
- Status changed from assigned to inprogress
fix doc - disable options, re #8456
Changeset: 5b3178a54d784dba0d8d12e062da6fb8c880184b
comment:4 Changed 6 years ago by Federico Montesino Pouzols
use OutputWorkspace property, don't override with suggestion, re #8456
Changeset: 9896565988a2b45033a643ada695210c6e5a25dd
comment:5 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
- Milestone changed from Backlog to Release 3.3
To fix this the name suggestion slot of LoadDialog has been changed. It now checks if the property 'OutputWorkspace' has ben set. I also corrected the LoadDialog Python documentation.
To test:
- Run the command given in the example (or similar):
LoadDialog("MAR11001.raw", OutputWorkspace="SomeSuggestion", Enable="Filename,OutputWorkspace")
- The load dialog should use 'SomeSuggestedWsName' as OutputWorkspace.
Note: I found the behavior of LoadDialog a bit confusing when enabling and disabling other options. For example, try not to enable 'OutputWorkspace', the filename seems to be ignored. I think there are issues in mantid/simpleapi.py that might need checking/fixing.
comment:6 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:7 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/8456_prevent_overwrite_of_output_ws_name_in_loaddialog'
Full changeset: 0a42593060d580ba07b4e08e533444bd6d17335a
bulk move to assigned at the into of the triage step