Ticket #8475 (closed: fixed)
Create new Version of Refl_gui using a UI file
Reported by: | Keith Brown | Owned by: | Keith Brown |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.1 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #7377 | Tester: | Owen Arnold |
Description (last modified by Keith Brown) (diff) ¶
The original Ref_Gui is written (badly) in pure python, a UI file is needed to make it more maintainable and allowing enhancements to be made easier, specifically for the later tasks associated with #7377
At this time the dialog should stay the same
Change History
comment:2 Changed 7 years ago by Keith Brown
- Description modified (diff)
- Summary changed from Create Ref_gui .ui file to Create new Version of Refl_gui using a UI file
comment:3 Changed 7 years ago by Keith Brown
Refs #8475 Fixing a dimension
I'd resized the hight to test that the other widgets resized too, but i'd forgotten to put it back.
It's worth noting that the old gui had a width of 1300 which wasn't suitable as that's wider that the most common resolution in use, 1024x768.
The default width is now 1000, the height remains 400.
Changeset: 41b456413d2bde2732d0b5287287aeab9f73f36a
comment:4 Changed 7 years ago by Keith Brown
Refs #8475 Python module created.
The Ui file has been run through pyqt4 and a script file has been generated.
Changeset: cbe9fe813820ed08b117f5b721b3e0c222089444
comment:5 Changed 7 years ago by Keith Brown
Refs #8475 Creates srcpits to inherit from and run the new window
refl_window contains a class that inherits from the auto-generated file so that I can add funtionality.
refl_gui_run.py is a temperary file i'm using during development to run the window outside of mantid.
Changeset: 8320416e9af045ce8cef1279b01163b59d5c25ca
comment:6 Changed 7 years ago by Keith Brown
Refs #8475 Table headers and combobox items now implemented
The table now has named headers and the comboboxes have their lists filled.
List has also been shrunk widthways.
Various widgets have been renamed.
Changeset: 9e9c6d69bd89b4a1451c42901ef8155d79288be2
comment:7 Changed 7 years ago by Keith Brown
Refs #8475 Replaced old version of ISIS Reflectonomy within mantidplot
Mantidplot now uses my newer vesion of the interface. The interface itself had to have an import stement altered due to the different location of the scripts.
The table hadn't been initilised properly in ym new version, fixed it.
Changeset: ab14e641fb6be15d5f25db3363d55a793827e2e9
comment:8 Changed 7 years ago by Keith Brown
Refs #8745 Corrected the table initialisation code.
The code initialising the table was using old code which was refferring to the table widget by its old name. Fixed
Changeset: e47738a888d79b39f677ea63cec874af4ef7351f
(this references the wrong ticket on github, the nonexistent 8745)
comment:9 Changed 7 years ago by Keith Brown
- Priority changed from major to critical
- Milestone changed from Backlog to Release 3.1
Found out that the transfer method isn't working at all even in the current release version.
Thus this ticket is being elevated to critical with the extension of making the existing functionality work as it should
comment:10 Changed 7 years ago by Keith Brown
Refs #8475 Fixed Transfer function
The transfer function was failing because when groupget is called the parameter "wksp" has a workspace passed to it directly, this means that the original calls to mtd[wksp] would fail as AnalysisManager would expect a string.
Checks have been added to see what type wksp is before it's actually used, calling the AnalysisManager only if it's a string, otherwise useing the workspace as it is. It's also treated differently if it's a WorkspaceGroup vs any other kind of workspace.
Even if that call to the AnalysisMAnager had worked it was also discovered that WorkspaceGroup haddn't been imported from mantid.api so it would have complained there too.
Once all the syntax and parameter problems had been sorted, it was found that the way the run numbers were added to the table was wrong, so that has also been fixed.
Changeset: 105d7ee37cf4420dfc5e2da7d62540cfe0af2f5a
comment:11 Changed 7 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
comment:13 Changed 7 years ago by Keith Brown
This should only be tested by Owen
comment:14 Changed 7 years ago by Keith Brown
- Status changed from verify to reopened
- Resolution fixed deleted
Refs #8745 Swapped file names and fixed some problems
refl_window and refl_gui have had thier names swapped to make more sense, as refl_gui was orinally the underlying window when actually being the interface wiht functionality would make more sense.
Discovered problems with the save, load and re-load functionality which I'm fixing.
comment:15 Changed 7 years ago by Keith Brown
previous commit went to wrong ticket
comment:16 Changed 7 years ago by Keith Brown
- Status changed from reopened to inprogress
Refs #8475 Save and Laod dialogs no longer throw on cancel
Before, when cancel was pressed on a save or load dialog it would throw an IOexception saying "file not found".
This was because the previous call was retrieving a string and when cancel was pressed that string was null. The script would then attempt to open whatever was in that string, regardless of the user pressing open/save or cancel.
In order to make it safer the dialog now calls the QFileDialog.exec_() in order to check if the user pressed Open/Save or cancel, then acts accordingly.
Changeset: 86d4bef8126f1167831dfaff1a7b4793d3f677c4
comment:17 Changed 7 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
comment:19 Changed 7 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8475_Ref_GUI_UI_File'
Full changeset: d18e10c364871e050479c7422cde970b3f37b42f
comment:20 Changed 7 years ago by Owen Arnold
All seems to work as I expect.
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9319
Refs #8475 Old gui replicated into a .ui file
The UI file has been made and just needs running through the script that will create the python module.
Changeset: d0a4af4ea30b747c6943b9cc32cd5cbee8aa8b66