Context Navigation

Ticket #8503 (inprogress)

Opened 7 years ago

Last modified 5 years ago

MantidMatrix cleanup

Reported by:	Russell Taylor	Owned by:	Dan Nixon
Priority:	minor	Milestone:	Backlog
Component:	GUI	Keywords:
Cc:		Blocked By:	#9952
Blocking:		Tester:

Description

It looks as though the MantidPlot MantidMatrix class could use a cleansing of now-redundant code left over from the days when plots generated from it were backed by a table. Certainly the code for updating the 1D plots in MantidMatrix::repaintAll() seems never to enter the loop. Not sure about the 2D part. MantidMatrix::setSpectrumGraph() seems unused. Possibly even the m_plots1D memeber variable is unneeded.

Change History

comment:1 Changed 7 years ago by Nick Draper

Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:2 Changed 6 years ago by Dan Nixon

Owner set to Dan Nixon

comment:3 Changed 6 years ago by Dan Nixon

Status changed from assigned to inprogress

Removed all table related code

Refs #8503

Changeset: 75c7a5b38e3b8b3d6fba41834e38a61615f7adcd

comment:4 Changed 6 years ago by Dan Nixon

All table/1D plot code could be removed as it is never used outside of MantidMatrix.

2D plots are not currently used because the code that loads them from a project file seems to be broken (#9952), this is the only instance of 2D plots inside a MantidMatrix being referenced outside MantidMatrix, all MantidMatrix does is redraw them. So it seems like this code is still needed assuming the mentioned ticket is resolved.