FitPeak does not work with EventWorkspace

[Wenduo Zhou]

FitPeak() cannot work on EventWorkspace because EventWorkspace does not allow Y value to be modified. But FitPeak() modifies some peak values to fit a background-removed peak. So the case of EventWorkspace must be concerned.

Meanwhile, it is convenient to add some feature #8182 mentions, i.e., put parameter names in the pulldown menu for the type of fit and background. Then the parameter values could be entered in that order by user and they do not have to know what parameter names go with each type of fit.

[Wenduo Zhou]

Added an extra output property and debug log. Refs #8518.

Changeset: 5e4c7801c4e787c7edab758fe386c49476249e3f

[Wenduo Zhou]

Enhance selection of peak type. Refs #8518.

Added peak types with peak parameter names other than pure peak types. If the peak type with peak parameter names is selected, then there is no need for user to specify peak parameters in 'PeakParameterNames'.

Changeset: 6159ec7c4386e28a9768d53a05eb89c008f31714

[Russell Taylor]

The solution with respect to event workspaces should be clear - the algorithm should not be modifying the input workspace, so an alternative way needs to be found. Then it will be transparent to an event workspace input. A last resort solution, though probably not ideal, would be to take a copy of the data before adjusting it. Wherever possible, the workspace should be passed around by reference-to-const shared_ptr (though this isn't possible where a child algorithm will be called).

[Wenduo Zhou]

Added background function with parameter prompt. Refs #8518.

Changeset: 4ca666c8f2f3e9da25225fa975dd2fe12e63e978

[Wenduo Zhou]

Generate a workspace instead of modifying input. Refs #8518.

Changeset: ad320e6eda50e356b049c05851221be53ea8d3c5

[Wenduo Zhou]

For Tester

You can test all the new features from one data file.

1. Load PG3_2538_event.nxs from SystemTest/Data;
2. Convert the unit to d-spacing if you like;
3. Rebin with bin size equal to -0.0004
4. Plot any spectrum with peak(s), such as 12222;
5. Use FitPeak to fit any peak of that spectrum. You only need to give some rough estimated value of peak height, centre and sigma (~0.001), fit range and peak range by simple observation;

You can choose the peak function 'Gaussian (.....)' and thus you don't need to give out the peak parameter names; You can choose the background function 'Quadratic (A0, A1, A2)', and thus you don't need to input background parameters' names;

6. Before, it won't work, because the workspace is event workspace. Now it should work with EventWorkspace.

[Russell Taylor]

There are a couple of ​cppcheck warnings that should be addressed.

[Wenduo Zhou]

Removed some cpp check error. Refs #8518.

Changeset: 4a81311e3a8e0ccc6eac936be95133d5bed202b8

[Wenduo Zhou]

Cleaned the code. Refs #8518.

Changeset: 8ba7cce319fa0cd559708b15b951e30622abfdb5

[Wenduo Zhou]

Fixed an error and modified error message. Refs #8518.

Changeset: f0f4ed56dcfaacbd0383b20b80417d71c55cfc1b

[Russell Taylor]

Merge remote branch 'origin/feature/8518_fitpeak_eventws'

Full changeset: ​183e129ecad53e886361bf28ef508824e280ccd0

[Stuart Campbell]

This ticket has been transferred to github issue ​9362