Ticket #8519 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Compiler warnings in LoadAscii2

Reported by: Russell Taylor Owned by: Keith Brown
Priority: minor Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

A bunch of GCC compiler warnings were added in #8509 - see for example ​http://download.mantidproject.org/jenkins/view/Master%20Clean%20Builds%20and%20Tests/job/is_clean_rhel6_master/1001/warnings15Result/

These need to be addressed.

Change History

comment:1 Changed 7 years ago by Keith Brown

  • Status changed from new to inprogress

Refs #8519 Fixed warnings and CppCheck errors

Addressed all the Gcc warnings and CppCheck errors i'd introduced in #8509

Changeset: f8b9e7e82a66948b856a599718e462beda319ee8

comment:2 Changed 7 years ago by Keith Brown

Refs #8519 numToSkip has to be an int

Changed numToSkip back to int and static_cast it to size_t when the comparison needed to happen.

The reason was the property didn't like being given a non-int

Changeset: a964a0a658ff7f7438e54ef5a5147cc703792a66

comment:3 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester, make sure all the warnings and CppCheck errors have gone

comment:4 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8519_LoadAscii_compiler_warnings'

Full changeset: ​a1fef3f0be70ee22a7a6c75ee71c5f7f15b8d2a9

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9363

Note: See TracTickets for help on using tickets.