Ticket #8520 (closed: fixed)
IDF free quick
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.1 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #8616, #8617, #8618 | Tester: | Peter Parker |
Description
One of the features requested by the reflectometry team is that we are able to run quick and explicitly pass all input parameters in rather than relying on the IDF instrument parameters.
Change History
comment:1 Changed 7 years ago by Owen Arnold
- Status changed from new to inprogress
- Milestone changed from Backlog to Release 3.1
comment:2 Changed 7 years ago by Owen Arnold
refs #8520. Use multidetector execution paths.
Changeset: dc268820cd136bf329ddcb941aee048712933bb2
comment:3 Changed 7 years ago by Owen Arnold
refs #8520. create quick_explicit
To help with backwards compatibility, I really don't want to break anything dependent on quick at this stage (including the reflectometry gui), so I want to leave that function API intact. Instead, I introduce a new function called quick_explicit, which quick will call.
Changeset: 73ef6be384e18bdfb0cfa35eddf29ad0899989a0
comment:4 Changed 7 years ago by Owen Arnold
refs #8520. Placeholder for correction object.
We need a way to pass correction strategies into quick rather than having it rely on the IDF definitions contained within. Wrapping up the algorithm calls so that they can be partially applied outside of quick is the most sensible way to do this. The new system tests are currently passing prior to making the change of swapping this functionality in.
Changeset: d6af85ddbf87ef8f176f6596ff1ed7a8718cb9f6
comment:5 Changed 7 years ago by Owen Arnold
refs #8520. Swap in new functionality and add tests.
Should now have no more force IDF parameter reads. You can do everything via the quick_explicit.
Changeset: 4c25372dec0dd40f44c105e1a3040637eee71b52
comment:6 Changed 7 years ago by Owen Arnold
Tester: The main point of this work was to be able to run the quick function in the quick script without having to fetch out arbitrary instrument parameters which may not exist. For backwards compatibility I have left the existing quick function untouched, but I have made it call quick_explicit with any instrument parameters that it needs. quick_explicit is public facing, so can be used by an external caller.
- Make sure that the new system test branch is also merged in.
- Check that the new system tests are passing and that none of the other ones have broken.
- Perform the same test listed here: http://trac.mantidproject.org/mantid/ticket/7372
comment:7 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:8 Changed 7 years ago by Russell Taylor
- Status changed from verify to reopened
- Resolution fixed deleted
You forgot to add the reference result for the system test.
comment:9 Changed 7 years ago by Owen Arnold
- Status changed from reopened to inprogress
refs #8520. Missing ref result.
Changeset: b71fb6a29902bd92fe8742bc08e0c156ae458307
comment:10 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:14 Changed 7 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:15 Changed 7 years ago by Peter Parker
Refs #8520 - Fix merge conflict.
Changeset: f8e1e2d3b771cba17dafae4647339a470133a05a
comment:16 Changed 7 years ago by Peter Parker
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8520_idf_free_quick'
Full changeset: c182ba78ef615e00a1f5251cf94aa21dc5bedc6d
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9364
