Ticket #8531 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Refl_gui Improvements - Selective Processing

Reported by: Keith Brown Owned by: Keith Brown
Priority: major Milestone: Release 3.1
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #7377, #8532, #8560 Tester: Owen Arnold

Description

At the moment, if you press process the refl_gui will process ALL the lines in the table. This is undesirable. It would be best to make the users select rows to process. If they don't select any, then pop-up a dialog when they hit process saying "You must select rows to process"

Change History

comment:1 Changed 7 years ago by Keith Brown

  • Component changed from Framework to Reflectometry
  • Milestone changed from Backlog to Release 3.1

comment:2 Changed 7 years ago by Keith Brown

  • Status changed from new to inprogress

Refs #8531. Added user check if the user has selected nothing

The user is now asked if they're sure they want to process all rows if no rows are selected.

Changeset: ae7b972c8e1d53d650ef62bbef186d1d18d21a2f

comment:3 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester (READ THE WARNING IN comment:4 BEFORE ACCEPTING FOR TESTING)

The gui in question is ISIS Reflectometry in Interfaces->Reflectometry

Load a tbl file into the gui which has a few lines to it (i.e. more than 2 - you may need to manufacture it)

Press 'process' without selecting any rows. The gui will show a yes/no question.

Then select a few rows using shift/ctrl clicking on the row headers, and press process. The gui won't ask the question.

Last edited 7 years ago by Keith Brown (previous) (diff)

comment:4 Changed 7 years ago by Keith Brown

There is a high chance this will cause merge conflicts as #8532 and #8549 also alter the same code as this ticket.

In the case of a merge conflict, fail the test and reopen so I can merge master into the branch and resolve it before submitting for testing again.

I believe the likelihood of conflicts will be increased if #8532 is merged before the this, so if possible, pass this first.

comment:5 Changed 7 years ago by Keith Brown

  • Blocking 8532 added

comment:6 Changed 7 years ago by Keith Brown

  • Blocking 8560 added

(In #8560) Added blocking tickets as they need to be pushed to master before I can finish this ticket as I'll need to merge them in.

comment:7 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:8 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This works as I would expect apart from in one situation. If you press Yes on the dialog, which asks about processing all rows, it does nothing. It should actually process all rows if you tell it to.

comment:9 Changed 7 years ago by Keith Brown

  • Status changed from reopened to inprogress

Refs #8531. Corrected script to process all rows

In my edits i had removed a line of code that would include all the rows int eh table, then neglected to put it back after adding the messagebox.

It has since been put back in the code, under the else clause of the Yes/No question response

Changeset: 1dc1760f84c324d3804cf2781006973116d687ab

comment:10 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Owen Arnold

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/8531_Refl_gui_selective_processing'

Full changeset: ​2b29464bcf488f938150f0e2b6588f7741d4e708

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9375

Note: See TracTickets for help on using tickets.