Ticket #8549 (closed: invalid)
Refl_gui Improvements - Remove Cycle selection
| Reported by: | Keith Brown | Owned by: | Keith Brown |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.1 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #7377, #8532, #8560 | Tester: | Owen Arnold |
Description
It seems the users have asked for the cycle selection to be removed as they're only interested in the latest cycle.
Remove this functionality as it's not being used
Change History
comment:2 Changed 7 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
comment:3 Changed 7 years ago by Keith Brown
To Tester:
WARNING
There is a high chance this will cause merge conflicts as #8531 and #8532 also alter the same code as this ticket.
In the case of a merge conflict, fail the test and reopen so I can merge master into the branch and resolve it before submitting for testing again.
I believe the likelihood of conflicts will be increased if #8532 is merged before the this, so if possible, pass this first.
To Test
The gui in question is ISIS Reflectometry in Interfaces->Reflectometry
This is mostly code inspection as the widget in question didn't appear in normal use.
Make sure you have a settings.xml file in place as detailed here http://www.mantidproject.org/ISIS_Reflectometry_GUI
Make sure all references to comboCycle and populating a list depending on a specific cycle (other than the most recent) are gone and that the widget no longer appears under any conditions on the gui.
comment:5 Changed 7 years ago by Keith Brown
- Blocking 8560 added
(In #8560) Added blocking tickets as they need to be pushed to master before I can finish this ticket as I'll need to merge them in.
comment:6 Changed 7 years ago by Keith Brown
Refs #8549. Working on Latest_isis_runs
As the scientists don't seem interested in other cycles, the latest_isis_runs script is bieng altered to return a list rather than a map
Changeset: c583d2a12fc108882bf7e95580452017cce75eaf
comment:7 Changed 7 years ago by Keith Brown
Above commit was linked to the wrong ticket, should have refed #8560 instead
comment:8 Changed 7 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:9 Changed 7 years ago by Owen Arnold
- Status changed from verifying to reopened
- Resolution fixed deleted
This has broken the latest run lookup functionality. It may be that this functionality is invalid given that the proper fix seems to be worked on in a different ticket.
comment:10 Changed 7 years ago by Keith Brown
- Status changed from reopened to verify
- Resolution set to invalid
comment:11 Changed 7 years ago by Keith Brown
this is indeed being fixed in #8560
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9393
Refs #8549. Removed Cycle combobox and functionality
The Qcombobox fro cycle selection has been removed form the ui
Any functionality depending on that widget has been removed
Changeset: a935b82502692ad4cb90c9e0dfd20409cfa8de03