Ticket #8601 (closed: fixed)
Add statistic information on GetDetOffsetsMultiPeaks()'s reuslt
Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | petersonpf@… | Blocked By: | #9020 |
Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Wenduo Zhou) (diff)
GetOffsetsMultiPeaks are going to modified to improve performance on calibrating powder diffractometers. The code should be refactored in order to make it convenient for future modification.
Its wiki should be improved for developer/user to understand better how this algorithm works.
The output information table workspaces should be ordered with spectrum indexes. If one spectrum does not have offset calculated, then the peak fitting result of this spectrum should not be added to PeakOffsetTableWorkspace,
It is convenient to add some statistic summary such that we can have a better view to tell whether new FitPeak/FindPeaks improve the performance of this algorithm.
Change History
comment:2 Changed 7 years ago by Wenduo Zhou
- Status changed from new to inprogress
Refactored codes for future development. Refs #8601.
Changeset: 8c9c8978e48a05a326b530f401dac97bc2820ec5
comment:3 Changed 7 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:4 Changed 7 years ago by Wenduo Zhou
- Status changed from verify to reopened
- Resolution fixed deleted
- Milestone changed from Backlog to Release 3.2
comment:6 Changed 7 years ago by Wenduo Zhou
- Status changed from reopened to inprogress
Refactored codes for future development. Refs #8601.
Changeset: 8c9c8978e48a05a326b530f401dac97bc2820ec5
comment:7 Changed 7 years ago by Wenduo Zhou
Minor changes for better output. Refs #8601.
Changeset: b78f9bce01731d0ae694ff78d0e1090a76ab3a40
comment:8 Changed 7 years ago by Wenduo Zhou
Added calculation for fit quality. Refs #8601.
- Refactored codes;
- Make wiki more detailed on the new features;
- Add new features including output the deviation of highest peak and
etc.
Changeset: af170624c8ed95f66fc3a76077062a8d5a20215f
comment:9 Changed 7 years ago by Wenduo Zhou
removed one debug output. Refs #8601.
Changeset: 7582aaf81b521ff0fdc6bc88df6481c3a8a8f02d
comment:10 Changed 7 years ago by Wenduo Zhou
Cleaned output table workspace. Refs #8601.
- Both output table workspaces are sorted;
- Empty lines in output peak position offset table workspace are
removed before output;
- Codes are refactoed for convenience of modifying.
Changeset: 9dc1529b11ad44c586daf430eb2a8d944d70dcf9
comment:12 Changed 7 years ago by Wenduo Zhou
Refactored the codes. Refs #8601.
Changeset: 6e82501e9a4de80a685f2020ee3de0676bd37a01
comment:13 Changed 7 years ago by Wenduo Zhou
Improved wiki and documentation. Refs #8601.
As well as cleaned out the comment and disabled code. Changed some log messages' levels.
Changeset: 2dc63939b75e6c90f07c31b9b50e2ba1e63e176a
comment:14 Changed 7 years ago by Wenduo Zhou
For tester
The major purpose of this ticket is to refactor the code and improve the output information about fitting.
- Check out branch feature/8601_getdetoffsets_more_stat;
- Run the the script as below """ CalibrateRectangularDetectors(OutputDirectory = savedir, SaveAs = 'calibration', FilterBadPulses = True,
GroupDetectorsBy = 'All', DiffractionFocusWorkspace = False, Binning = '0.5, -0.0004, 2.5', MaxOffset=0.01, PeakPositions = '.6866,.7283,.8185,.8920,1.0758,1.2615,2.0599', CrossCorrelation = False, Instrument = 'PG3', RunNumber = '2538', Extension = '_event.nxs') """
Data can be found in system test;
- You can find some statistic on the fitting result reported by log in notice level;
- Check the output information table workspace. You can find that the rows are ordered by spectra's workspace indexes;
- In the PeakOffsetInformationTableWorskpace, you can find that some spectra are missing. These spectra that are actually masked.
comment:15 Changed 7 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:16 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:17 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to closed
The outputs are as described
comment:18 Changed 7 years ago by Roman Tolchenov
Merge remote-tracking branch 'origin/feature/8601_getdetoffsets_more_stat'
Full changeset: b872ec9f2f7644dc040606457b206e07c5300316
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9445
Moved to backlog at the end of Release 3.1