Ticket #9020 (closed: fixed)
Fix some issues of FindPeakBackground
Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.2 |
Component: | Diffraction | Keywords: | |
Cc: | petersonpf@…, lynchve@… | Blocked By: | |
Blocking: | #7789, #8601, #8878 | Tester: | Peter Peterson |
Description
There are several issues or problems of algorithm FindPeakBackground.
- It is not helpful for this algorithm to work on multiple spectra by single calling. So make FindPeakBackground operate on 1 spectrum a time.
- FindPeaks may not use FindPeakBackground correctly. Verify and correct the error if there is any.
Change History
comment:2 Changed 7 years ago by Wenduo Zhou
- Status changed from assigned to inprogress
Refactored FindPeakBackground. Refs #9020.
- Refactored and thus fixed some issues;
- Added more unit tests;
- Change input property. Algorithm can work with 1 spectrum only.
Changeset: 441a4bb8376cd2d0a0e2827b9d56807a71b9304f
comment:3 Changed 7 years ago by Wenduo Zhou
Adapted to new algorithm property. Refs #9020.
Changeset: 8437353745febffa5f3aefc8f0b60c6a15e1c206
comment:4 Changed 7 years ago by Wenduo Zhou
Make unit test to remove all genrated workspaces. Refs #9020.
Changeset: 1755937b270ea3853a823ff3a279ebec9fce3e4c
comment:5 Changed 7 years ago by Wenduo Zhou
For tester
The changes in this ticket include a change in input property (WorkspaceIndices to WorkspaceIndex) and refactoring the code. The behavior of the algorithm should not change. What you can do:
- Check whether the unit tests and system tests are passed.
- Load some data with peaks and run the algorithm on it to find peaks' background.
comment:6 Changed 7 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:7 Changed 7 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:8 Changed 7 years ago by Peter Peterson
- Status changed from verifying to reopened
- Resolution fixed deleted
At lines 123-124 you raise an exception if the workspace index is not specified. This is not necessary if the input workspace only has one spectrum.
comment:9 Changed 7 years ago by Wenduo Zhou
- Status changed from reopened to inprogress
Enable algorithm to accept 1 spectrum ws w/o. specify. Refs #9020.
Changeset: 6533dc128bd7bb3c5d84631b010a018d7964c338
comment:10 Changed 7 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Peter Peterson
- Status changed from verifying to closed
Merge remote branch 'origin/feature/9020_fix_findpeakbkgd'
Full changeset: ec6563c3f5e6ff5f0f7c38ac133fc066e3c458d0
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9863