Ticket #8623 (closed: fixed)
Read characterization into table workspace
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Diffraction | Keywords: | |
Cc: | Blocked By: | #8635 | |
Blocking: | #8675 | Tester: | Andrei Savici |
Description (last modified by Peter Peterson) (diff)
SNSPowderReduction relies heavily on the "characterization" file which contains information about settings for focus positions and other processing information. Convert the reading into an algorithm that loads into a table workspace for the data ranges and characterization run numbers and output parameters for the focus positions, and the iparm filename.
Change History
comment:4 Changed 7 years ago by Peter Peterson
- Status changed from new to inprogress
Re #8623. Initial version from class_maker.
Changeset: f7868634bdd09b75aa8bc3db8166803d464b14d3
comment:5 Changed 7 years ago by Peter Peterson
Re #8623. Adding properties to the algorithm and making it compile.
Changeset: 540b827eb0d7222208144f7ec6bafcc65f9ff3fc
comment:6 Changed 7 years ago by Peter Peterson
Re #8623. Adding test files.
Changeset: 1f4e05bd3f4e07996bbc436e1f660204907aa5d4
comment:7 Changed 7 years ago by Peter Peterson
Re #8623. First fully functioning version.
There is only one test written so far and it needs documentation, but otherwise it is good.
Changeset: 7bb321cb96e45420265a500d0fac64835687ce8a
comment:8 Changed 7 years ago by Peter Peterson
Re #8623. Adding doxygen.
Changeset: 4de6572e0c0cec2241f51606d73e15fbd1cc22a6
comment:9 Changed 7 years ago by Peter Peterson
Re #8623. Filled in another test and fixed the bug it exposed.
Changeset: 882d053eab05eaddd8c2975d29a9b6995121638e
comment:10 Changed 7 years ago by Peter Peterson
Re #8623. Getting NOMAD test working.
Changeset: f870ac16de8ee354a5451dfd524a3a17c53cf3c9
comment:11 Changed 7 years ago by Peter Peterson
Re #8623. Adding another NOMAD test.
The previous one was for a NOMAD oddity, this time do the actual focus position only one.
Changeset: 39feaa75a864bf024a7297426c0eb7be4a8ec0dc
comment:12 Changed 7 years ago by Peter Peterson
Re #8623. Refactored test to remove some duplicate code.
Changeset: e239b05ce4214f392afaf077b81e870387ff5bcc
comment:13 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is on feature/8623_characterization_file.
To test: See if the unit tests cover the standard cases. The real test is when #8675 (which this ticket is blocking) is done. Otherwise, try it on random characterization files which means it will need to be tested by an SNS person.
comment:14 Changed 7 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:15 Changed 7 years ago by Andrei Savici
- Status changed from verifying to reopened
- Resolution fixed deleted
wiki documantation (including initDocs function) are the autogenerated ones.
Note: some test files create table with no rows (that's OK, but just be aware of that)
comment:17 Changed 7 years ago by Peter Peterson
Re #8623. Adding wiki documentation.
Changeset: f05d98b5edb444dc705d0cfdb9c0ceb97a294c85
comment:18 Changed 7 years ago by Peter Peterson
Re #8623. Changing the algorithm category.
Changeset: 9b477a4fd09ca0b630c250d2f1153cb8b00a52f4
comment:19 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:21 Changed 7 years ago by Peter Peterson
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:22 Changed 7 years ago by Peter Peterson
- Status changed from reopened to inprogress
Re #8623. Adding a 'real' short algorithm description.
Changeset: 644f272af94629290d303119dd3a3141db567894
comment:23 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:25 Changed 7 years ago by Andrei Savici
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8623_characterization_file'
Full changeset: 4c5e8d018f0e145f545e51b9b7e561fd029a1ad3
comment:26 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9467