Ticket #8635 (closed: fixed)
ASCII file functions in Kernel::Strings
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #8623 | Tester: | Russell Taylor |
Description
Since this is where much of the string stuff is already located, move some utility functions from DataHandling::LoadAscii to here for use by others. The main ones are:
- LoadAscii::peekLine
- LoadAscii::skipLine
There should also be a change to Strings::strip to just use boost::trim. Also, LoadAscii::isAscii should just call FileDescriptor::isAscii.
Change History
comment:2 Changed 7 years ago by Peter Peterson
Re #8635. Moving functions over. Old places are just passthrough.
Changeset: 2a6658c0e27392955b21e957479926954cff03bc
comment:3 Changed 7 years ago by Peter Peterson
Re #8635. Hopefully fixing broken windoze build.
Changeset: 2b484a0619eea65f10ac9df347ae20c6c8a02384
comment:4 Changed 7 years ago by Peter Peterson
Re #8635. Fixing mixed up tests.
Changeset: 8b2b71d1d3dc807bb8cb2f474b8ec2442add35a9
comment:5 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is on feature/8635_kernel_strings.
To test: Make sure all of the tests still pass and that the functions have been moved to their new homes.
comment:7 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:8 Changed 7 years ago by Peter Peterson
Re #8635. Using the correct kind of delete now.
Changeset: dc4a8da3eb3d0da867c444f5b47d3f3a6c2ee950
comment:9 Changed 7 years ago by Peter Peterson
Re #8635. Added tests and fixed the bugs they exposed.
As per Russell's requests.
Changeset: 45d361c18ca3890193646a40686198d89596fac1
comment:10 Changed 7 years ago by Peter Peterson
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:11 Changed 7 years ago by Peter Peterson
- Status changed from reopened to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Andrei Savici
- Status changed from verify to closed
Merge remote-tracking branch 'origin/feature/8635_kernel_strings'
Full changeset: 80a7abacabcd207f87f97ba3edd519df8ca107cc
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9479
Re #8635. Moved LoadAscii::isAscii into FileDescriptor
Changeset: 2e0d9237bdb909f9d25bc270488a874c7b2990cb