Ticket #8637 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Enable Step Scan interface to accept series of non-ADARA runs as points in the scan

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 3.1
Component: GUI Keywords:
Cc: Blocked By: #8638, #8669
Blocking: Tester: Andrei Savici

Description

Pre-ADARA, a scan could be saved as a series of runs where each run represents a point in the scan (in order). We should be able to construct a workspace that will work with StepScan by adding the scan_index log with the appropriate value for each workspace and then adding the workspaces together.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Blocked By 8638 added

comment:2 Changed 7 years ago by Russell Taylor

  • Blocked By 8669 added

comment:3 Changed 7 years ago by Russell Taylor

  • Component changed from Framework to User Interface

comment:5 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #8637. Clone the input workspace if filtering or masking.

Avoids the input workspace potentially being changed by the algorithm.

Changeset: c261608adcb223c59c0a9b0f8b58f06772a2e9ac

comment:6 Changed 7 years ago by Russell Taylor

Re #8637. Lose the flag for reloading the data.

No longer needed now that I'm good and never modify the input workspace to the StepScan algorithm.

Changeset: 9b85b8ffc44a6f438424e22ca39a40dab6ccb079

comment:7 Changed 7 years ago by Russell Taylor

Re #8637. Add capability to specify multiple runs.

Each run is treated as a single point in the scan (in the order they're given), a scan_index entry is inserted and the runs are merged together. They can then be treated as other scan runs. This allows scans from non-ADARA-enabled instruments to use the functionality of this interface.

The loading algorithm had to be changed from LoadEventNexus to Load for this. This then required changes around that code to catch if the user tries to load the wrong kind of file.

Changeset: c6df2d39ae69e3526d94eabe5fca9473d3801e79

comment:8 Changed 7 years ago by Russell Taylor

Re #8637. Disable GUI and show hourglass while merging runs.

Changeset: 6dbd43b3bda72685ddb3ab2c3666526b7d44082f

comment:9 Changed 7 years ago by Russell Taylor

Re #8637. Add a scan_index=0 entry at the end time of each run.

Will make the normalization and calculations of average log values more correct.

Changeset: de9205b1a6b8467ba1e36c6690177b3e693096fe

comment:10 Changed 7 years ago by Russell Taylor

Re #8637. Add a text label that can be used to report status.

And add reporting of what operation the interface is undertaking where it might take a noticeable amount of time.

Changeset: 3a794e073e8d32364e1f46f82b043e58cfd60eb5

comment:11 Changed 7 years ago by Russell Taylor

Re #8637. Make the GUI more responsive...

...by running algorithms asynchronously and processing events in the meantime so that the whole of MantidPlot doesn't lock up.

Changeset: e046a8881f48da191520f00906de091448d3663c

comment:11 Changed 7 years ago by Russell Taylor

Re #8637. Move fetching the monitor workspace up to StepScan.

And pass into SumEventsByLogValue by a new optional property. My changes to avoid changing the input workspace were leading to a failure to find the monitors by SumEventsByLogValue.

Changeset: c2eeecf79aec861f2a2442872bf02c1719e3bacd

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester: Branch is feature/8637_stepscan_preadara_group

Test by selecting multiple event nexus files in the file browser (or entering comma-separated runs) and make sure the files are loaded correctly and the plot is successfully generated when 'Start' is pressed.

You could also check that loading a non-event nexus file or a single non-adara file produces an appropriate error message.

To check that nothing's gone wrong with the previous 'success' path, the file to use is HYSA_2934.nxs.h5 in the systemtests repository and live connections may be possible to HYS, SEQ or VIS (but likely won't be outside the cycle).

comment:13 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:14 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8637_stepscan_preadara_group'

Full changeset: 23c31cf1e1a374180f6c21cd55787545abd5a3e4

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9481

Note: See TracTickets for help on using tickets.