Ticket #8700 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[Muon] Seq. fitting: no need to store loaded workspaces

Reported by: Arturs Bekasovs Owned by: Arturs Bekasovs
Priority: major Milestone: Release 3.1
Component: Muon Keywords:
Cc: Blocked By:
Blocking: #8716 Tester: Samuel Jackson

Description

I am storing loaded workspaces for all the seq. fits in the group as well. This is just to get the log values to add to results table.

If I copy the log values from loaded workspace to the '*_Workspace' worskpace when the fit is done, there is no need to do that. This will not only reduce the amount of memory used, but can be handy for users:

Right clicking on the grouped fits from the sequential fitting and selecting 'plot spectrum' produces a lovely graph of all the data. But, of course, the first workspace in the group contains only the data so there's no option for including the fits. Deleting the data (workspaces without an extension) allows data and fits to be plotted by simply right clicking on the group name. I wonder if there's a neater solution. Do we need the data workspaces as the data is also in the '*_Workspace' workspaces?

Change History

comment:1 Changed 7 years ago by Arturs Bekasovs

  • Status changed from new to inprogress

Refs #8700. Namespace clean-up.

Changeset: d1cffd7331e7ac919af9ee45f9f23c50acc60857

comment:2 Changed 7 years ago by Arturs Bekasovs

Refs #8700. Adding logs to *_Workspace when doing a single fit.

Changeset: 596e0dcb2d0f73692ab34f4c29b147d33c223810

comment:3 Changed 7 years ago by Arturs Bekasovs

Refs #8700. Adding a logs to *_Workspace in seq. fit.

Changeset: b7562cbf34f3e4e834a9b0f1a68629a4f701d542

comment:4 Changed 7 years ago by Arturs Bekasovs

Refs #8700. Change the way list of fitted workspaces is retrieved.

Now we just take a list of all *_Workpace workspaces and work with them. Original data is not required anymore.

Changeset: 180baf36139a35efc7b0ddff43beec712083a82f

comment:5 Changed 7 years ago by Arturs Bekasovs

Refs #8700. No need to store loaded seq. fitting workspaces.

Changeset: 885b47841455201d3523e4cdef696329db9d0563

comment:6 Changed 7 years ago by Arturs Bekasovs

Refs #8700. Minor code clean-up.

Changeset: ed0f64fb2d8f7ef173df03045822afbc2b31cbb4

comment:7 Changed 7 years ago by Arturs Bekasovs

Refs #8700. Merge branch 'feature/8700_muon_seq_fit_loaded_ws' into develop

Conflicts:

Code/Mantid/MantidQt/MantidWidgets/src/MuonFitPropertyBrowser.cpp

Changeset: 9d018d8c6c6a799bad55e428589e618dc036949d

comment:8 Changed 7 years ago by Arturs Bekasovs

Tester:

Using a couple of various data sets, check that results table is generated properly. Try using different instruments and multiple fit models.

Check that sequential fitting groups contain fitting result workspaces only and you can plot them in the way Steve described.

Last edited 7 years ago by Arturs Bekasovs (previous) (diff)

comment:9 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 7 years ago by Keith Brown

  • Status changed from verify to verifying
  • Tester set to Keith Brown

comment:11 Changed 7 years ago by Keith Brown

  • Status changed from verifying to verify
  • Tester Keith Brown deleted

comment:12 Changed 7 years ago by Arturs Bekasovs

  • Blocking 8716 added

comment:13 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:14 Changed 7 years ago by Arturs Bekasovs

Refs #8700. Merge remote-tracking branch 'origin/master' into 8700

Conflicts:

Code/Mantid/MantidQt/MantidWidgets/src/MuonFitPropertyBrowser.cpp

Changeset: 1aa95d1b86937728d0c9b191fe9e8cbb302ef6e7

comment:15 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8700_muon_seq_fit_loaded_ws'

Full changeset: 7ad91264fb2d1261bbbf29b277de0e1e8c095f9e

comment:16 Changed 7 years ago by Arturs Bekasovs

Refs #8700. Merge branch 'feature/8700_muon_seq_fit_loaded_ws' into develop

Conflicts:

Code/Mantid/MantidQt/MantidWidgets/src/MuonFitPropertyBrowser.cpp

Changeset: 9d018d8c6c6a799bad55e428589e618dc036949d

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9544

Note: See TracTickets for help on using tickets.