Ticket #8716 (closed: fixed)
Fitting result filtering
Reported by: | Arturs Bekasovs | Owned by: | Arturs Bekasovs |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Muon | Keywords: | |
Cc: | Blocked By: | #8700 | |
Blocking: | Tester: | Jay Rainey |
Description
Now with sequential fitting dialog in place the amount of fitting results users have to deal with might become quite big.
That's why, should come up with a good way of filtering the fits on Results tab. It should be easy to find all the fits of the certain label and view individual fits only.
Change History
comment:3 Changed 7 years ago by Arturs Bekasovs
Refs #8716. Add UI controls for filtering.
Changeset: 672e3f58b54b4a4bdbd71bcdc9a78fec46109406
comment:4 Changed 7 years ago by Arturs Bekasovs
Refs #8716. Make seq. fit prefix a static constant.
In that way it can be used safely in other places.
Changeset: def24a50a1d1041fbb625e20ea805dc074d20575
comment:5 Changed 7 years ago by Arturs Bekasovs
Refs #8716. Replace string vectors with string lists.
It's easier to use lists and there is no particular reason to use vectors.
Changeset: 06f4b237ff6138e040655fde1001d145f64d36c6
comment:6 Changed 7 years ago by Arturs Bekasovs
Refs #8716. Add basic filtering functionality.
Changeset: 7695bcf6116e2bcbff0762ef0d672738732d4adb
comment:7 Changed 7 years ago by Arturs Bekasovs
Refs #8716. Add error handling for when group was deleted.
Changeset: 43f7d380f5132ed487b6b42e743617005e0400c8
comment:8 Changed 7 years ago by Arturs Bekasovs
Refs #8716. Remove irrelevant messages and do a slight refactoring.
Changeset: 9cb7972f794ecc6ece1f44b7ddbfd99de8a5d1a4
comment:9 Changed 7 years ago by Arturs Bekasovs
Refs #8716. Make empty list case handling better.
Changeset: 93b8ae85b0209cec15493d901d74fe0f9c8f85bf
comment:10 Changed 7 years ago by Arturs Bekasovs
Tester:
Open Results tab before doing any fits. Check that it behaves correctly when there is nothing to show.
Now do multiple individual and sequential fits for various instruments and fit models and go to the Results tab again. Check that it's easy enough to find both individual fits and sequential fits for a specific label.
List of logs should be updated together with list of workspaces representing common logs for all these workspaces. Workspaces with different fit models should have different colors in the list and should not be available to be included in the same results table.
Try to make another sequential fit and return to the Results tab - new label should be added to the combo box.
I've not touched any of results table creation code, though just in case make sure the table does actually gets created with the right data sets, logs and fit parameters.
comment:11 Changed 7 years ago by Arturs Bekasovs
- Status changed from inprogress to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Arturs Bekasovs
- Summary changed from [Muon] Fitting result filtering to Fitting result filtering
comment:13 Changed 7 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:14 Changed 7 years ago by Jay Rainey
- Status changed from verifying to closed
To test this ticket I grabbed an older version of Mantid to verify how the interface functioned.
- Results tab behaves correctly when no results are found.
- I performed several standard fits on various instruments. The results appeared in the Individual fits table as expected.
- When I performed sequential fits (on various instruments and datafiles) the result was output into the sequential fit table. The drop-menu was populated with the name of the sequential fit as expected.
- When I clicked Create table the correct results of the included fit tables are created in a joined table.
In other words, the changes introduced allow the user to perform multiple fitting/sequential fits without getting lost in the results tab. This makes the user-experience significantly better.
The code is well written, and I could not see any problems/bad practice.
comment:15 Changed 7 years ago by Jay Rainey
Merge remote-tracking branch 'origin/feature/8716_muon_results_filtering'
Full changeset: 7ac1ce8a7e79ca3a14d1055932cad3df3d0750d0
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9560