Ticket #8715 (closed: fixed)
RB, ExperimentId, InvestigationNumber
Reported by: | Owen Arnold | Owned by: | Jay Rainey |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Owen Arnold |
Description
All of these are used in various places. There should be a single name used here. The fact that these things are the same should be documented on the wiki. All algorithm properties using these should point to that documentation.
Change History
comment:3 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state
comment:4 Changed 6 years ago by Jay Rainey
- Status changed from assigned to verify
- Resolution set to fixed
I performed a grep on the Mantid repo and found that RB was used predominately in the ISIS reflectometry GUI while investigation number was used in the new ICAT algorithms. This was also the case when performing a wiki search for RB number and investigation ID.
I updated the wiki of each GUI and algorithms to ensure it was noted what each meant. This can be verified by reviewing my recent wiki changes:
I do not want to change information within the reflectometry or ICAT algorithms to specify RB number as the ICAT algorithms are facility independent, and the users of each GUI may not be familiar with the other name (e.g. investigation number on the Reflectometry GUI).
To test
Note: there is no branch as the changes have been made directly on the wiki.
- Verify that the wiki changes indicate other name uses.
- Verify that I did not miss any other documentation (perform searches on the wiki).
comment:5 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold