Ticket #8725 (closed: fixed)
[ICAT] CatalogPublish missing DLLExport
Reported by: | Jay Rainey | Owned by: | Jay Rainey |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.1 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Arturs Bekasovs |
Description
I noticed that I did not include DLLExport when creating CatalogPublish. For consistency, and possible direct DLL call to this algorithm I will need to include it.
Change History
comment:2 Changed 7 years ago by Jay Rainey
- Status changed from inprogress to verify
- Resolution set to fixed
This is a minor consistency change that can be verified with a code review.
comment:3 Changed 7 years ago by Arturs Bekasovs
- Status changed from verify to verifying
- Tester set to Arturs Bekasovs
comment:4 Changed 7 years ago by Arturs Bekasovs
Missing DLLExport was indeed added. Though to be 100% consistent I think it's worth using a EXPORT_OPT_MANTID_ICAT macro defined in ICatExport.h. A ticket for that: #8728.
comment:5 Changed 7 years ago by Arturs Bekasovs
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8725_icat_publish_dllexport'
Full changeset: 65590bacdf17dc358143a78aa6156a2aa7460941
Note: See
TracTickets for help on using
tickets.
Added missing DLLExport. Refs #8725.
Changeset: 644db73038d54139ff2b87ce85e653e855a535d1