Ticket #8751 (closed: invalid)

Opened 7 years ago

Last modified 5 years ago

System test parameter entries

Reported by: Owen Arnold Owned by: Keith Brown
Priority: blocker Milestone: Release 3.1
Component: Reflectometry Keywords:
Cc: Blocked By: #8693
Blocking: Tester: Owen Arnold

Description

Given the stability issues we've been seeeing recently, and those reported by our reflectometry testers. The optional point that did not get done in 8693 should be completed:

Create system tests that ensure that for all of these instruments the parameters are being made available (don't worry about the values as these may change). A good way to do this might be to have an abstract base class and have concrete classes to provide the data for each instrument. See ReflectometryISIS.py system test as a guide.

This will provide us with a good early warning system around both IDF and parameter file changes that are critical to the current functioning of the reflectometry reduction.

Change History

comment:1 Changed 7 years ago by Keith Brown

Please see commit 16132bae6edfde1b6e0265dc2963c7d6c1de4aa0 from #8693 as there were system tests written in that

comment:2 Changed 7 years ago by Keith Brown

  • Status changed from new to verify
  • Resolution set to invalid

comment:3 Changed 7 years ago by Owen Arnold

Indeed, you've done a good job of this, and I overlooked the new system tests during verification of this ticket

comment:4 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9595

Note: See TracTickets for help on using tickets.