Ticket #8752 (closed: fixed)
Fix ccp check issue.
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Jay Rainey |
Description
CPP check issues in some of my reflectometry code needs fixing. http://download.mantidproject.org/jenkins/view/Static%20Analysis/job/is_cppcheck_master/4017/cppcheckResult/ ReflectometryWorkflowBase (unreachable code).
Change History
comment:2 Changed 7 years ago by Owen Arnold
Tester: This is fixed if the ReflectometryWorkflowBase cpp check issue has disappeared from the develop branch of cpp check. http://download.mantidproject.org/jenkins/view/Static%20Analysis/job/is_cppcheck_develop/. It won't be cleared from the master version till after the ticket has been passed and closed.
comment:3 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:4 Changed 7 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:5 Changed 7 years ago by Jay Rainey
- Status changed from verifying to reopened
- Resolution fixed deleted
This error still occurs on the develop build as you are throwing an exception and the IF block below it is never reached - here
comment:8 Changed 7 years ago by Owen Arnold
refs #8752. Cpp check issue around if.
Changeset: 5b9a7123ccdc0031afe37551cf187f2edd49129c
comment:9 Changed 7 years ago by Owen Arnold
Revert "refs #8752. Cpp check issue around if."
This reverts commit 5b9a7123ccdc0031afe37551cf187f2edd49129c.
Changeset: f9b415ab8b6f4108022cad31c0f839bcd71d0702
comment:10 Changed 7 years ago by Owen Arnold
Revert "Revert "refs #8752. Cpp check issue around if.""
This reverts commit f9b415ab8b6f4108022cad31c0f839bcd71d0702.
Changeset: 5125e1702966288601977f95c4e2ba68b046d2d2
comment:11 Changed 7 years ago by Owen Arnold
refs #8752. Warning is not required.
Changeset: 265a8d7da8022f65feec2cca86698f39b0ff3220
comment:12 Changed 7 years ago by Martyn Gigg
The last commit introduced a compiler warning. Details here
comment:13 Changed 7 years ago by Owen Arnold
refs #8752. Kill warning and proper fix.
Changeset: 970c80b7a2c18fb53b28cc01991f8bdf99154576
comment:14 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:16 Changed 7 years ago by Jay Rainey
- Status changed from verifying to closed
The initial CPP check as noted in comment:5 has been addressed, as has the other noted by Martyn in comment:12. The refactoring has not affected the functionality.
comment:17 Changed 7 years ago by Jay Rainey
Merge remote-tracking branch 'origin/feature/8752_fix_cpp_check_issue'
Full changeset: 16db86a8062ee744a5000c842746e33ee1bd2517
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9596
refs #8752. Fix single cpp check issue.
Changeset: 6df745a20936c2c9b650c94b212a677e8217b6f2