Ticket #8768 (closed: fixed)
Indirect ConvFit has file loading issues
Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Jay Rainey |
Description
I get an unhandled exception if I try to run ConvFit after deleting a file it expects to exist before running. Fix it.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
To Tester:
First confirm you can reproduce the error:
- Open the IDA interface.
- Select ConvFit and run with any appropriate files. See this link for instructions:
http://www.mantidproject.org/Indirect:Indirect_Data_Analysis
- Now delete all the files produced, including the sample run.
- Attempt to re-run and you'll get a high level exception
Then check that the fix works. Doing the same thing should cause the LoadNexus to be run and use the file path to attempt to reload the file.
comment:3 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:4 Changed 7 years ago by Samuel Jackson
- Status changed from verify to reopened
- Resolution fixed deleted
Spotted that this issue is also present in FuryFit. Will attempt similar solution.
comment:5 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #8768 Fix duplicate issue in FuryFit.
Changeset: b108c1353a95ab7f0f5155846a1a98515f310a78
comment:6 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Tester:
As above, but do it for FuryFit as well. (Use Fury to output a file that can be run with FuryFit).
comment:7 Changed 7 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:8 Changed 7 years ago by Jay Rainey
- Status changed from verifying to closed
The two exceptions noted in this ticket have been dealt with accordingly.
When running Fury it completes successfully. However, I came across a few other issues when testing other IDA interfaces to verify they did not have the same problem. The problem encountered was:
- When running Fury if I delete all of the workspaces (while the GUI is open) and click Run nothing happens and an error is thrown:
ValueError: Invalid value for property Filename (string) "irs26174_graphite002_red.nxs": File "irs26174_graphite002_red.nxs" not found at line 3 in '<Interface>' caused by line 566 in 'C:/MantidInstall/bin\mantid\simpleapi.py' caused by line 530 in 'C:/MantidInstall/bin\mantid\simpleapi.py'
Re-opened as this issue is related to those in the ticket.
comment:9 Changed 7 years ago by Jay Rainey
- Status changed from closed to reopened
- Resolution fixed deleted
comment:10 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to inprogress
Refs #8768 Use full file path when reloading.
This will only effect users loading a file outside their managed directories.
Changeset: c0d0bdd74cfb28fefa61cf8fdd77fd763ea0690e
comment:11 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Tester: As above, but just check Fury this time.
comment:13 Changed 7 years ago by Jay Rainey
- Status changed from verifying to closed
The change in comment:10 address the issue I noted in comment:8 (this occurred as I did not have the directory of the datafiles setup in my 'Manage directories'). The other changes implemented solve the problem, and an unhanded exception is no longer thrown. There are no CPP warnings, and the code appears to be correct.
comment:14 Changed 7 years ago by Jay Rainey
Merge remote-tracking branch 'origin/bugfix/8768_convfit_file_loading_issues'
Full changeset: 3b91b4c9aa41698423d66c346b7134f61b9c3e78
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9612
Refs #8768 Attempt to reload file if it's been removed from ADS
Changeset: 20aaaf82d56d288abd204d82b70b56b3f5b7fb35