Ticket #8769 (closed: fixed)
Change to LoadMcStas
Reported by: | Anders Markvardsen | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.1 |
Component: | Framework | Keywords: | |
Cc: | torben.nielsen@… | Blocked By: | |
Blocking: | Tester: | Jay Rainey |
Description
Torben writes:
Can we change LoadMcStas.cpp line 412 412 nxFile.getAttr("title", nameAttrValueTITLE); to 412 nxFile.getAttr("filename", nameAttrValueTITLE);
Change History
comment:2 Changed 7 years ago by Anders Markvardsen
To tester:
- Load from AutoTestdata the file mcstas_event_hist.h5
- Expand the created GroupWorkspace and it should contain more preferred names for the workspaces such as in this case 'Edet.dat_mcstas_event_list'
comment:3 Changed 7 years ago by Anders Markvardsen
- Status changed from new to inprogress
changed how workspace names are outputted. re #8769
Changeset: 239293560b3987c381ebe67cb261dbde83449230
comment:4 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
Note I committed to the branch for this ticket the following:
fix build server. re #8709
Changeset: a4ef1c73edf4081da7459111fc32e49e7a60aa5f
comment:5 Changed 7 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:6 Changed 7 years ago by Jay Rainey
- Status changed from verifying to closed
There are no system tests failing, or any issues with the code. I tested with an old version of Mantid (to verify the names prior to the change) and another with the change. The change introduced addresses the issue noted in the description.
comment:7 Changed 7 years ago by Jay Rainey
Merge remote-tracking branch 'origin/feature/8769_load_mcstas_change'
Full changeset: d536946bbb7c35619358716f21513fc75612414c