Ticket #8844 (closed: fixed)
New IDF for SANS2D
Reported by: | Gesner Passos | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.2 |
Component: | SANS | Keywords: | |
Cc: | richard.heenan@… | Blocked By: | |
Blocking: | #8845, #8921 | Tester: | Karl Palmen |
Description
SANS2D has a new detector bank based on tubes. It is necessary to create its IDF.
Attachments
Change History
Changed 7 years ago by Gesner Passos
- Attachment SANS2D_Definition_tubes.xml added
Richard created this IDF for SANS2D
comment:2 Changed 7 years ago by Anders Markvardsen
- Status changed from new to inprogress
Richard Heenan new sans2d idf. re #8844
Changeset: 3c7889cdda00511a90fae75db81ea66403ad3a8f
comment:4 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Cc richard.heenan@… added
- Resolution set to fixed
To tester:
- test that it loads in Mantidplot
- test that it has not broken any systemtests
comment:5 Changed 7 years ago by Russell Taylor
FYI: SANS2D system tests got a bit slower due to this change, though that may well be inevitable. See https://builds.sns.gov/view/Tests/job/ornl_test_rhel6_develop/System_tests_performance/ for details.
comment:6 Changed 7 years ago by Anders Markvardsen
Hi Russell, this worries me slightly. Perhaps I am not looking at the right place, but looking at the performance of e.g. SystemTests.SANS2DFrontNoGrav.SANS2DFrontNoGrav the history revision records was last updated on 2nd Feb and the commit in comment 2 is on 7th Feb. Can you remind me where to look more specifically?
comment:7 Changed 7 years ago by Gesner Passos
Is it not necessary to change the valid-to of the old one?
comment:8 Changed 7 years ago by Anders Markvardsen
- Status changed from verify to reopened
- Resolution fixed deleted
good point.....
comment:9 Changed 7 years ago by Anders Markvardsen
Although valid-to is an optional tag it is clearer if this is updated for the old IDF (or removed)
comment:10 Changed 7 years ago by Anders Markvardsen
- Status changed from reopened to inprogress
change valid-from for old sans2d idf. re #8844
Changeset: b675bbfebb2940e42f9d85ea10df4cf0077cbe20
comment:11 Changed 7 years ago by Anders Markvardsen
Revert "change valid-from for old sans2d idf. re #8844"
This reverts commit b675bbfebb2940e42f9d85ea10df4cf0077cbe20.
Changeset: 09cadbec6ab54b364230118e9311f3481da0c833
comment:12 Changed 7 years ago by Anders Markvardsen
change to valid-to. re #8844
Changeset: 32942b23df9d982709b2c4639ef9b722b68ace69
comment:13 Changed 7 years ago by Anders Markvardsen
revert all changes. re #8844
with the only purpose to see if this cause a change to performance of the sans systemtests
Changeset: 5415948fc4840e3414c8f551f855afe5ad166eb1
comment:14 Changed 7 years ago by Anders Markvardsen
Revert "revert all changes. re #8844"
This reverts commit 5415948fc4840e3414c8f551f855afe5ad166eb1.
Changeset: 28824d859165a8cf03d84f2eab460cc9a1ebd734
comment:15 Changed 7 years ago by Anders Markvardsen
Note separate ticket created to improve performance of checkting which IDF to load in #9054
comment:16 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
To tester:
test that SANS2D_Definition_tubes.xml loads in Mantidplot
test that it has not broken any systemtests
Observation about performance will be dealt with in separate ticket #9054
comment:17 Changed 7 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:18 Changed 7 years ago by Karl Palmen
IDF loads without error. View instrument works and shows a good picture.
System tests are failing at the moment so I'll hold onto this test, till Monday, when hopefully the system tests will be fixed.
comment:19 Changed 7 years ago by Karl Palmen
System tests have worked.
comment:20 Changed 7 years ago by Karl Palmen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8844_new_sans2d_idf'
Full changeset: 59d544d5970ef44760400255e8cad86db4e2818d
comment:21 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9688