Ticket #8939 (inprogress)

Opened 7 years ago

Last modified 5 years ago

catalog insensitive search by name

Reported by: Jay Rainey Owned by: Karl Palmen
Priority: major Milestone: Backlog
Component: Framework Keywords: ICAT
Cc: Blocked By:
Blocking: Tester:

Description

Currently, in the algorithm, UI, and related classes the Investigators name field is refereed to as InvestigatorSurname, which is mis-leading (in fact, it's what the field was previously used as).

If I attempt to search via Investigators name the results returned are not correct, for example, if I search for jay rainey, it does not return any results. However, if I search for Jay Rainey it returns the correct results.

The search for the investigators name therefore needs to be made case insensitive.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:2 Changed 6 years ago by Jay Rainey

An issue has been raised regarding usage of LOWER/UPPER. Once ICAT 4.3.3 gets rolled out to ICATDEV (likely some point this week) then this ticket can be addressed.

comment:3 Changed 6 years ago by Jay Rainey

  • Status changed from assigned to inprogress

Rename investigatorSurName to investigatorName. Refs #8939.

Changeset: e7f73890af13fe02843f178b1b54c28d50b35a7f

comment:4 Changed 6 years ago by Jay Rainey

Updated algorithm and interface references to surname. Refs #8939.

  • Also updated the error label name for DataFileName.

Changeset: fe0974be4908a3bab445ec48ba1be444c50df58c

comment:5 Changed 6 years ago by Jay Rainey

Updated references to surname in catalogs. Refs #8939.

Changeset: c7b9b679eb1e8de2edc38e53e0379e9653c0c8fe

comment:6 Changed 6 years ago by Jay Rainey

Improved logging messages in CatlogDownloadDataFiles. Refs #8939.

Changeset: 0b65f790e95f15e47b3f2e5633443d87c68205a7

comment:7 Changed 6 years ago by Jay Rainey

  • Owner changed from Jay Rainey to Karl Palmen

The previous commits above deal with updating the surname attribute in the ICAT Search algorithm to the more generic name.

The next part of this ticket (which is not yet done) deals with updating the search query that is sent to ICAT to be lowercase, e.g. using LOWER(). This ensures that if the user enters "Jay" or "jay" into the investigators name field the query will return the correct results.

As noted in comment:2, there has been an issue opened for the exact cause of this problem. The change has been made and will be introduced to ICAT 4.3.3. Therefore, this ticket cannot be completed until ICAT 4.3.3 is released onto the production server. To find out when this will be done you will need to get in contact with Tom Griffin.

When working on this ticket, please use the following branch as it already has the name changes:

Last edited 6 years ago by Jay Rainey (previous) (diff)

comment:8 Changed 6 years ago by Karl Palmen

  • Milestone changed from Release 3.2 to Release 3.3

comment:9 Changed 6 years ago by Nick Draper

Moved to the backlog at the code freeze of R3.3

comment:10 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Backlog

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9782

Note: See TracTickets for help on using tickets.