Ticket #8940 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Kill latest cppcheck warnings

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 3.2
Component: Framework Keywords: Maintenance,
Cc: Blocked By: #7582, #8880, #8881
Blocking: Tester: Russell Taylor

Description


Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Blocked By 8880, 8881 added

comment:2 Changed 7 years ago by Martyn Gigg

  • Status changed from new to inprogress

Fix setting the arguments for cppcheck

This way it doesn't include the CACHE stuff from cmake in the call to cppcheck. Refs #8940

Changeset: da38d5d80cc3803482fd452c94631eb06762b39b

comment:3 Changed 7 years ago by Martyn Gigg

Fix cppcheck errors in SCDPanelErrors.

Refs #8940

Changeset: e3e9f49e4630b2e5054dc38e5e077e7687ef9de5

comment:4 Changed 7 years ago by Martyn Gigg

Fix duplicate branch cppcheck error in SaveHKL

Refs #8940

Changeset: 551ef35fda136e4e95828c4f4b5ee21444d28b1a

comment:5 Changed 7 years ago by Martyn Gigg

Reduce scope of variable in SplineSmoothing. Fixes cppcheck error.

Refs #8940

Changeset: 087961d59564f46afa2ff86f8ff42d650ba56a0c

comment:6 Changed 7 years ago by Martyn Gigg

Reduce scope of variables in TobyFitYVector, fixes cppcheck issue.

Refs #8940

Changeset: 2c80cf91f342d7a378d0aa902187b8c7c472ca22

comment:7 Changed 7 years ago by Martyn Gigg

Remove unused variable in ScriptingWindow, fixing cppcheck issue.

Refs #8940

Changeset: 49408130df7b3470c3baf5b904f982cbc29d5b24

comment:8 Changed 7 years ago by Martyn Gigg

Remove suppressions no longer required by cppcheck 1.63

Refs #8940

Changeset: 4d88a394282c11fc9ccc1171cbeae5516a24cc03

comment:9 Changed 7 years ago by Martyn Gigg

  • Keywords Maintenance, added; Maintenance removed

comment:10 Changed 7 years ago by Martyn Gigg

  • Blocked By 7582 added

comment:11 Changed 7 years ago by Martyn Gigg

Use boost::isnan to avoid cppcheck error and for clearer code!

Refs #8940

Changeset: 9aaec2c313c16b8b258ad76ced198230a8c98fee

comment:12 Changed 7 years ago by Martyn Gigg

Put back cpp suppression that cppcheck still requires.

Refs #8940

Changeset: 4b42f86e4f34391e01feabcf149dea80dbe2c513

comment:13 Changed 7 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: bugfix/8940_cppcheck-fixes

Tester: See the latest results ​here The remaining issues are to be addressed by a refactoring #8997.

comment:14 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:15 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/8940_cppcheck-fixes'

Full changeset: ​8ec78a6fb13fc2c621743d177dd67fa3fb6ddc1d

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9783

Note: See TracTickets for help on using tickets.