Ticket #8946 (inprogress)
Change slice2histogram to use FilterEvents
| Reported by: | Gesner Passos | Owned by: | Peter Parker |
|---|---|---|---|
| Priority: | major | Milestone: | Backlog |
| Component: | SANS | Keywords: | |
| Cc: | peter.parker@… | Blocked By: | |
| Blocking: | Tester: |
Description
Probably, it would be worth using the GenerateEventsFilter as well.
The FilterByTime is to be replaced.
Change History
comment:2 Changed 7 years ago by Gesner Passos
The change is not straightforward. There are some issues to do this:
GenerateEventFilter would create a Table workspace that would be ok for us to create a single entry or to create many entries. The issue, is that to have the logs splited correctly, it is required to do have the filtered and the unfiltered workspaces. This would greatly impact the performance for a workspace that we will have to delete.
Another possibility is to use these two algorithms as they were designed. Use the GenerateEventFilter to generate all the slices and apply these slices once at all through the FilteEvents.
The issue here is that it requires changing the design of how the reduction is dealing with event workspaces in SANS. The only solution I foreseen is inserting it inside the loader it self. On loading, it would get the definition of the slices and slice all the data. The main issue with this approach is the user interface. Currently, the user interface requires pressing the LOAD button and then the 1D Reduction. And it would require loading and slicing twice for every single reduction.
