Ticket #8967 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

BASIS geometry fix

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: critical Milestone: Release 3.1.1
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

The North side banks were found to have been flipped around. This needs to be fixed.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Michael Reuter

  • Keywords PatchCandidate added

comment:3 Changed 7 years ago by Michael Reuter

Refs #8967. Fixing polar angle issue for North side.

Changeset: 4949ad5acd0e5cd3637cdf7bd50189f9990ae400

comment:4 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found ​here.

To test: Load BASIS run 23741 and look at the instrument view. The downstream portion of the detector should be open.

comment:5 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:6 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/8967_basis_geometry_fix'

Full changeset: ​cd299bd63e72b57725bed395c32e48f8ec9f61c1

comment:7 Changed 7 years ago by Michael Reuter

This is actually incorrect. The physical pixels were in the correct locations. It was just the ghost tubes that are in the wrong place.

comment:8 Changed 7 years ago by Michael Reuter

  • Keywords PatchCandidate removed

Need to undo the change.

comment:9 Changed 7 years ago by Russell Taylor

  • Milestone changed from Release 3.2 to Release 3.1.1

Formally, this has to go into the patch release to keep git happy, but it's the outcome of #9021 that supersedes this.

comment:10 Changed 7 years ago by Michael Reuter

Refs #8967. Fixing polar angle issue for North side.

Changeset: 85f8683a0a08378cd104227908b02de365e3bb12

comment:11 Changed 7 years ago by Russell Taylor

The commit in comment:10 is from cherry-picking the changes over to the patch release branch.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9811

Note: See TracTickets for help on using tickets.