Ticket #8977 (inprogress)

Opened 7 years ago

Last modified 5 years ago

Calculate Transmission Polynomial

Reported by: Gesner Passos Owned by: Peter Parker
Priority: major Milestone: Backlog
Component: SANS Keywords:
Cc: Blocked By: #9030
Blocking: Tester:

Description

In calculate transmission, the polynomial order is to be applied to the log of the data, as specified by the scientist:

Are we actually fitting the polynomial to the Log(Trans) ? - Which is what I intended.

Attachments

check_calculate_transmission.py (1.4 KB) - added by Gesner Passos 7 years ago.
check8977.py (1.1 KB) - added by Gesner Passos 7 years ago.
check8977_real_example.py (494 bytes) - added by Gesner Passos 7 years ago.
21005_trans_several_errors.pdf (23.1 KB) - added by Gesner Passos 7 years ago.
What we do not want as answer. But it depends on #9030.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Milestone changed from Backlog to Release 3.2

comment:2 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

re #8977: Make Polynomial of Log(trans) for calculate transmission

Changeset: 1d1acca699d159cb604a4a01a5c19f0f814a0ab7

comment:3 Changed 7 years ago by Gesner Passos

  • Blocking 9011 added

While doing this ticket I've spotted an issue with the error propagation #9011

comment:4 Changed 7 years ago by Gesner Passos

  • Blocking 9011 removed

Changed 7 years ago by Gesner Passos

comment:5 Changed 7 years ago by Gesner Passos

Tester:

If rebining is not present, fitting the CalculateTransmission can be reproduced outside as:

  • Log(xxx_unfitted)
  • Fit
  • Exp

The check_calculate_transmission shows how I did this to check the result. The result should be the same except for the error because of the issue presented in #9011.

comment:6 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 7 years ago by Gesner Passos

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:8 Changed 7 years ago by Gesner Passos

It broke the systemtest LOQReductionGUI.LOQMinimalBatchReduction.

It is ok. That specific test uses as Mask the MaskLOQData.txt which has the following line:

FIT/TRANS/CAN/POLYNOMIAL4 2.2 10.0

Now, we have changed the polynomial to be applied in the Log(trans). Hence, having the results changing is a good signal.

comment:9 Changed 7 years ago by Gesner Passos

  • Status changed from reopened to inprogress

re #8977: Update file that uses polynomial fit.

Changeset: f4bc5d79fd1c4a632c33a936c066198b9a88a125

comment:10 Changed 7 years ago by Gesner Passos

  • Blocked By 9030 added

comment:11 Changed 7 years ago by Gesner Passos

#9030 will cause the Errors in Fit to change, this will effect CalculateTransmission. Hence, before applying this ticket, specially because it changes Systemtest data, it is better to wait for #9030.

Changed 7 years ago by Gesner Passos

comment:12 Changed 7 years ago by Gesner Passos

Tester:

You can use check8977.py to check this ticket as well, it is a variation of the one proposed in #9011 to allow checking for the Polynomial fit.

comment:13 Changed 7 years ago by Gesner Passos

Peter:

Because #9030 is delayed (waiting for the green signal from Martyn), I won't be able to push this one. comment:2 is the commit that implements what is required in this ticket. You will probably need to run again the systemtest that produced the comment:9 because it was done before the addition of #9030.

As soon as this pass, please inform Richard who is keen to test this new feature.

Changed 7 years ago by Gesner Passos

comment:14 Changed 7 years ago by Gesner Passos

The check8977_real_example.py allows you to check against a real use-case proposed from the user.

comment:15 Changed 7 years ago by Gesner Passos

  • Owner changed from Gesner Passos to Peter Parker

Changed 7 years ago by Gesner Passos

What we do not want as answer. But it depends on #9030.

comment:16 Changed 6 years ago by Peter Parker

  • Milestone changed from Release 3.2 to Release 3.3

I have yet to look into this, but it seems that Gesner had possibly completed this but was just waiting for another ticket to clear. I will take a look after the release.

comment:17 Changed 6 years ago by Nick Draper

Moved to the backlog at the code freeze of R3.3

comment:18 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Backlog

comment:19 Changed 6 years ago by Peter Parker

Merge branch 'master' into feature/8977_calculate_transmission_poly

Conflicts:

Code/Mantid/Framework/Algorithms/src/CalculateTransmission.cpp

Refs #8977

Changeset: 3ccb3b011120bb73360e721a6951ec7e213fafe6

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9820

Note: See TracTickets for help on using tickets.