Ticket #8976 (closed: fixed)
Extend LoadGSASInstrumentFile to also load GSAS file into workspace instrument parameters
Reported by: | Karl Palmen | Owned by: | Raquel Alvarez Banos |
---|---|---|---|
Priority: | major | Milestone: | Release 3.5 |
Component: | Diffraction | Keywords: | |
Cc: | zhouw@… | Blocked By: | #8980, #9260, #9261 |
Blocking: | Tester: | Karl Palmen |
Description
We need an algorithm rather like LoadFullprofResolution that reads a GSAS file and loads parameters into the instrument parameters of a workspace.
This ticket is likely to require several steps of work that can be put into separate tickets blocking this one. This may include a step to define this ticket more precisely.
Change History
comment:2 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state
comment:6 Changed 6 years ago by Anders Markvardsen
- Owner changed from Karl Palmen to Raquel Alvarez Banos
comment:7 Changed 6 years ago by Anders Markvardsen
- Summary changed from Algorithm to load GSAS file into workspace instrument parameters to Extend LoadGSASInstrumentFile to also load GSAS file into workspace instrument parameters
comment:9 Changed 6 years ago by Anders Markvardsen
- Cc anders.markvardsen@… removed
- Component changed from Framework to Diffraction
comment:10 Changed 6 years ago by Raquel Alvarez Banos
For tester:
- Load a dataset, for instance MUSR00015189
- Run SaveParameterFile, you should get something like:
<?xml version="1.0" encoding="UTF-8"?> <parameter-file valid-from="1900-01-31T23:59:59" instrument="MUSR"> <component-link name="MUSR"> <parameter name="Default grouping file - Longitudinal" type="string"> <value val="Grouping/MUSR_Detector_Grouping_LF_64.xml"/> </parameter> <parameter name="Default grouping file - Transverse" type="string"> <value val="Grouping/MUSR_Detector_Grouping_TF_64.xml"/> </parameter> </component-link> </parameter-file>
i.e., with no fitting parameters.
- Now run LoadGSASInstrumentFile algorithm with "GSAS_Y2O3_SI_132v.prm" as input file. Select your workspace as "Workspace". You must provide two bank IDs in "Banks". Run the algorithm.
- Run SaveParameterFile again, you should get an output with some parameters in it:
-<parameter-file valid-from="1900-01-31T23:59:59" instrument="MUSR"> <component-link name="MUSR"> <parameter name="Default grouping file - Longitudinal" type="string"> <value val="Grouping/MUSR_Detector_Grouping_LF_64.xml"/> </parameter> <parameter name="Default grouping file - Transverse" type="string"> <value val="Grouping/MUSR_Detector_Grouping_TF_64.xml"/> </parameter> <parameter name="IkedaCarpenterPV:Alpha0" type="fitting"> <formula result-unit="TOF" unit="" eq="0"/> </parameter> ... </component-link> </parameter-file>
comment:11 Changed 6 years ago by Raquel Alvarez Banos
- Milestone changed from Release 3.3 to Release 3.4
comment:12 Changed 5 years ago by Nick Draper
- Milestone changed from Release 3.4 to Release 3.5
Moved to R3.5 at the R3.4 code freeze
comment:13 Changed 5 years ago by Raquel Alvarez Banos
- Status changed from assigned to verify
- Resolution set to fixed
This was an umbrella ticket.
comment:14 Changed 5 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:15 Changed 5 years ago by Karl Palmen
File "GSAS_Y2O3_SI_132v.prm" found attached to ticket #9260.
comment:16 Changed 5 years ago by Karl Palmen
- Status changed from verifying to closed
Test works on a branch recently created from master.
But I noticed that the formulae lines weren't nested appropriately in the parameter. If this needs fixing, it can be done in new ticket.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9819