Ticket #9261 (closed: fixed)
Enable the GSAS instrumenent file loading algorithm to add Ikeda Carpenter PV parameters to workspace
Reported by: | Karl Palmen | Owned by: | Raquel Alvarez Banos |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | Framework | Keywords: | |
Cc: | anders.markvardsen@…, zhouw@… | Blocked By: | #9260, #9380 |
Blocking: | #8976, #10862 | Tester: | Wenduo Zhou |
Description (last modified by Martyn Gigg) (diff)
Extend the algorithm created by ticket #9260 to put Ikeda Carpenter PV parameters into a workspace as described in http://www.mantidproject.org/CreateIkedaCarpenterParametersGSAS in a manner similar to what LoadFullprofResoulution does.
Attachments
Change History
comment:4 Changed 7 years ago by Martyn Gigg
- Status changed from new to assigned
- Owner set to Karl Palmen
comment:7 Changed 6 years ago by Anders Markvardsen
- Owner changed from Karl Palmen to Raquel Alvarez Banos
comment:8 Changed 6 years ago by Raquel Alvarez Banos
- Milestone changed from Release 3.3 to Release 3.4
comment:9 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from assigned to inprogress
Re #9261 Update documentation
Changeset: 86cfb8a13281b5ebedcb419eb3323bc58007767c
comment:10 Changed 6 years ago by Raquel Alvarez Banos
Re #9261 public createBankToWorkspaceMap and rowNumbers
Changeset: 7e7e602ec8989150eed13414d3966a5a48e94837
comment:11 Changed 6 years ago by Raquel Alvarez Banos
Re #9261 public createBankToWorkspaceMap and rowNumbers
Changeset: 585f2fb6327bf02dd71c76786f6e56aa4e367a3c
comment:12 Changed 6 years ago by Raquel Alvarez Banos
Re #9261 update LoadGSASInstrumentFile
Changeset: d09f1493d6a39af5612d0679d20070000f0826fc
comment:13 Changed 6 years ago by Raquel Alvarez Banos
Re #9261 fixing cppcheck
Changeset: c780d57edad52080b0e741f3e61c040ff9f42a13
comment:14 Changed 6 years ago by Raquel Alvarez Banos
I have noticed that some GSAS instrument files will not be loaded correctly by LoadGSASInstrumentFile. The algorithm parses an instrument definition file with a three line header per bank, however this is not always the case. Having a look at the GSAS manual and examples, I found the file attached. When loading it, the output table shows wrong values of the parameters. Ticket #10739 has been created to solve this issue.
comment:15 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from inprogress to verify
- Resolution set to fixed
Test as described in #8976
comment:16 Changed 6 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:18 Changed 6 years ago by Raquel Alvarez Banos
- Blocking 10862 added
- Blocked By 10862 removed
comment:19 Changed 6 years ago by Wenduo Zhou
- Status changed from verifying to reopened
- Resolution fixed deleted
As I merged the branch feature/9261_enable_GSAS_loader_to_add_ICPV_parameters to master, here is the error message: ERROR: Branch 'feature/9261_enable_GSAS_loader_to_add_ICPV_parameters' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments.
comment:20 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from reopened to inprogress
Re #9261 Put parameters into workspace
Changeset: 90046a99cc3c7735599dc9c6aaa368b282ef1b77
comment:21 Changed 6 years ago by Raquel Alvarez Banos
Re #9261 removing unused variable nProf
Changeset: 9f7fa89ad206024dd53517fdd1d570a1aba6757c
comment:22 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from inprogress to verify
- Resolution set to fixed
comment:24 Changed 6 years ago by Wenduo Zhou
The result looks fine to me.
One of my question is whether the Ikeda Carpenter PV is the profile 14 in GSAS.
comment:25 Changed 6 years ago by Wenduo Zhou
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9261_enable_GSAS_loader_to_add_ICPV_parameters'
Full changeset: b5aaad4753ad7bc5b05bc1617ddfe701fbe98932
comment:26 Changed 6 years ago by Raquel Alvarez Banos
According to the GSAS manual, it seems to me that the profile for the ICPV is number 2. Not sure about the number of parameters, in the manual it is stated that there are 15 parameters for this function, but I am not sure if this is always the case or you can have less than 15.
comment:27 Changed 5 years ago by Nick Draper
Somehow these slipped through without a resolution. Set to Fixed.
comment:28 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10104
(In #8976) Tickets #9260 and #9261 have been created as part of the work for this ticket.