Ticket #9260 (closed: fixed)
Create algorithm to load GSAS instrument file and put results into table workspace
Reported by: | Karl Palmen | Owned by: | Karl Palmen |
---|---|---|---|
Priority: | major | Milestone: | Release 3.2 |
Component: | Framework | Keywords: | |
Cc: | anders.markvardsen@…, zhouw@… | Blocked By: | |
Blocking: | #8976, #9261 | Tester: | Wenduo Zhou |
Description
Create and algorithm to load a GSAS file like the one shown in http://www.mantidproject.org/CreateIkedaCarpenterParametersGSAS and put the results into a table workspace OutputTableWorkspace like what LoadFullprofResolution does.
The algorithm could be called LoadGSASInstrumentFile, because SaveGSASInstrumentFile produces a file of similar but not exactly the same format.
Attachments
Change History
comment:2 Changed 7 years ago by Karl Palmen
- Blocking 8976 added
(In #8976) Tickets 9260 and 9261 have been created as part of the work for this ticket.
comment:4 Changed 6 years ago by Karl Palmen
Consultation with Wenduo has revealed that the algorithm may be called LoadGSASInstrumentFile.
comment:6 Changed 6 years ago by Karl Palmen
Create non-functioning stub of algorithm re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 3902cf6593a9fc97595ca1a368031318f4d8a402
comment:7 Changed 6 years ago by Karl Palmen
Add code to check histogram type re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 76c6e5bd94f4c0f0346fc10a6f309b5c20580cbe
comment:8 Changed 6 years ago by Karl Palmen
Get number of banks re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: ac48a053053180cd16305983cc6498ab69a15651
comment:9 Changed 6 years ago by Karl Palmen
Add function to get number of banks re #9260
This function presently only works when this number has a single digit. lexical_cast<int> does not accept space characters.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 161da83225876c30191b1b6bdbf2814d85c2c429
comment:10 Changed 6 years ago by Russell Taylor
There are a bunch of gcc compiler warnings: https://builds.sns.gov/view/Wall%20display/job/ornl_clean_rhel6_develop/3083/warnings17Result/
comment:11 Changed 6 years ago by Karl Palmen
I will deal with these when I return to work on this ticket after testing. Some of the warnings are a consequence of incomplete work.
comment:12 Changed 6 years ago by Martyn Gigg
This may get covered with the compiler warnings but there is also a cppcheck error: http://download.mantidproject.org/jenkins/view/Static%20Analysis/job/is_cppcheck_develop/536/cppcheckResult/
comment:13 Changed 6 years ago by Karl Palmen
Deal with compiler warnings re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 13a633ed4f1f914ca5635767a69ee1c04d2b76da
comment:14 Changed 6 years ago by Karl Palmen
Added code to find banks re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: da4040878dd0de21c22eea19367fa0c49cb22c46
comment:15 Changed 6 years ago by Karl Palmen
Create Output table workspace (with just 2 rows) re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 9aab2b8c31e0c4726c8a69e83c7ef192dc2e849f
comment:16 Changed 6 years ago by Karl Palmen
Read first four parameters of each bank re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: a0428988ba65fec0b7051e18fc9c77f5331caa28
comment:17 Changed 6 years ago by Karl Palmen
Add other parameters to output table workspace re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: ed309d164e88177852b11a1121c7fca28ea50417
comment:18 Changed 6 years ago by Karl Palmen
Add unit test LoadGSASInstrumentFileTest.h re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: cba6e0e4e3a25eb7a4d51754b9ffef3739a72faa
comment:19 Changed 6 years ago by Martyn Gigg
There are some compiler warnings in LoadGSASInstrumentFile
comment:20 Changed 6 years ago by Karl Palmen
Correct case in include of LoadGSASInstrumentFile.h re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 9f109df76d2ba4fcfe757db35e756ac9e69fba4c
comment:21 Changed 6 years ago by Karl Palmen
Add test for invalid Histogram type re #9260
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: b5537160481f0efc6b274bc2e32f9c023b2c6425
comment:22 Changed 6 years ago by Karl Palmen
To test:
Check that the unit test is adequate.
Run with attached .prm file or similar. See that it runs without error and produces a table workspace with Alpha, Beta, Gamma, Sigma and NPROF parameters like what LoadFullProfResolution would. You may run LoadFullprofResolution for comparison.
comment:23 Changed 6 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
comment:24 Changed 6 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:25 Changed 6 years ago by Wenduo Zhou
The algorithm works fine.
One suggestion for wiki. It is better to have a link to the wiki page about GSAS instrument file of this algorithm's wiki.
comment:26 Changed 6 years ago by Wenduo Zhou
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9260_load_gsas_instrument_file'
Full changeset: 4fd3ce0090bc1bde07ae85042e25853eb82090dd
comment:27 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10103