Ticket #9033 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Correct error in FindPeaks related to calling FindPeakBackground

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Wenduo Zhou) (diff)

There seems to be some errors in FindPeaks about how to uses the result from FindPeakBackground.

It is found later that there is no error in FindPeaks to use the result from FindPeakBackground. But as is is possible for FindPeakBackground to output some obviously wrong result, it is better to make FindPeaks to handle these kind of situation. The observed erroneous results include index of peak's left boundary is larger than peak's right boundary and estimated background is zero while the background is not zero at all.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to infoneeded

Wenduo,

Can you please add a description to this ticket, to help tester, and other devevlopers should you get hit by a bus.

comment:2 Changed 7 years ago by Wenduo Zhou

Minor changes in golden files. Refs #9033.

Changeset: d86f7ea42a017965f881cbb5f4f7446d09e76803

comment:3 Changed 7 years ago by Wenduo Zhou

Added some comments and log output. Refs #9033.

Changeset: 3a6b6bbaa3db04592c5c96fe0d838f492be4619f

comment:4 Changed 7 years ago by Wenduo Zhou

Enhanced analyzing FitPeakBackground's result. Refs #9033.

Changeset: 81605bb789d2db1583bdb34fd1b41d91757e8d1b

comment:5 Changed 7 years ago by Wenduo Zhou

Changed some log levels. Refs #9033.

Changeset: 7572fc0d518bfb040691f60b62f799dc87784c3e

comment:6 Changed 7 years ago by Wenduo Zhou

For tester

The change is mainly about adding criteria on the result of FindPeakBackground. Please

  1. check whether all the unit tests are passed;
  2. check whether the changes of the system tests' reference files are reasonable.

comment:7 Changed 7 years ago by Wenduo Zhou

  • Status changed from infoneeded to new
  • Description modified (diff)

comment:8 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to assigned
  • Description modified (diff)

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:10 Changed 7 years ago by Wenduo Zhou

Resolved conflict. Refs #9033.

Changeset: 787fa41b7f170a2c54f56988b705c7a81ea1cefc

comment:11 Changed 7 years ago by Andrei Savici

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/bugfix/9033_correct_findpeakbkgd'

Full changeset: ​df144865c588411fe3cb9bbec84c0c17e71cccdd

comment:12 Changed 7 years ago by Andrei Savici

Merge remote-tracking branch 'origin/bugfix/9033_correct_findpeakbkgd'

Full changeset: ​86fb994aca16018d027289f49ac77462c5667b60

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9876

Note: See TracTickets for help on using tickets.