Ticket #9034 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SaveGSASInstrumentFile fails because of changes in LoadFullProfResolution

Reported by: Karl Palmen Owned by: Wenduo Zhou
Priority: critical Milestone: Release 3.2
Component: Diffraction Keywords:
Cc: anders.markvardsen@…, zhouw@… Blocked By:
Blocking: Tester: Peter Peterson

Description

The algorithm SaveGSASInstrumentFile is no longer able to convert fullprof .irf file to GSAS.

It is evident that this is because of recent changes to fullProfResolution.

Add unit test to detect such a failure.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Owner set to Karl Palmen
  • Status changed from new to infoneeded

karl, please attach or provide the path to an example file that cannot be loaded.

comment:2 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:3 Changed 7 years ago by Karl Palmen

I expect it to fail with any .irf file.

It fails with both the files in AutoTestData 2001B_HR60b2.irf and PG3_Bank.irf .

comment:4 Changed 7 years ago by Karl Palmen

  • Status changed from infoneeded to new

comment:5 Changed 7 years ago by Nick Draper

  • Owner changed from Karl Palmen to Wenduo Zhou
  • Status changed from new to assigned

comment:6 Changed 7 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

comment:7 Changed 7 years ago by Wenduo Zhou

Added a unit test to expose the problem. Refs #9034.

Changeset: 5313d943d32996374c6632bd004923d6c5847dc8

comment:8 Changed 7 years ago by Wenduo Zhou

Fixed the problem. Refs #9034.

The problem was caused by change of one LoadFullprofResolution's input property's name.

Changeset: 315d8bf447ac09107eb8a1c97d687a433c23a298

comment:9 Changed 7 years ago by Wenduo Zhou

For tester

  1. Locate 2001B_HR60b2.irf and PG3_Bank.irf in AutoTestData;
  2. Run SaveGSASInstrumentFile by loading the .irf file directly. You can leave the 'Bank' empty to default. You will see that the algorithm throws an exception;
  3. Merge the change in this ticket to master;
  4. Re-run as step 2. You can see that the algorithm is executed successfully.
  5. Check the new unit test.

comment:10 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:12 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/9034_save_gsas_error'

Full changeset: ​27cf68d378ceb2697c1fbf586eb26e66e19b5447

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9877

Note: See TracTickets for help on using tickets.